b2f4ffb98a
# What this PR does Remove [`apps.get_model`](https://docs.djangoproject.com/en/3.2/ref/applications/#django.apps.apps.get_model) invocations and use inline `import` statements in places where models are imported within functions/methods to avoid circular imports. I believe `import` statements are more appropriate for most use cases as they allow for better static code analysis & formatting, and solve the issue of circular imports without being unnecessarily dynamic as `apps.get_model`. With `import` statements, it's possible to: - Jump to model definitions in most IDEs - Automatically sort inline imports with `isort` - Find import errors faster/easier (most IDEs highlight broken imports) - Have more consistency across regular & inline imports when importing models This PR also adds a flake8 rule to ban imports of `django.apps.apps`, so it's harder to use `apps.get_model` by mistake (it's possible to ignore this rule by using `# noqa: I251`). The rule is not enforced on directories with migration files, because `apps.get_model` is often used to get a historical state of a model, which is useful when writing migrations ([see this SO answer for more details](https://stackoverflow.com/a/37769213)). So `apps.get_model` is considered OK in migrations (even necessary in some cases). ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
51 lines
1.8 KiB
Python
51 lines
1.8 KiB
Python
from celery.utils.log import get_task_logger
|
|
from django.utils import timezone
|
|
|
|
from apps.base.utils import live_settings
|
|
from apps.oss_installation.cloud_heartbeat import send_cloud_heartbeat
|
|
from apps.oss_installation.usage_stats import UsageStatsService
|
|
from common.custom_celery_tasks import shared_dedicated_queue_retry_task
|
|
|
|
logger = get_task_logger(__name__)
|
|
|
|
|
|
@shared_dedicated_queue_retry_task()
|
|
def send_usage_stats_report():
|
|
logger.info("Start send_usage_stats_report")
|
|
from apps.oss_installation.models import OssInstallation
|
|
|
|
installation = OssInstallation.objects.get_or_create()[0]
|
|
enabled = live_settings.SEND_ANONYMOUS_USAGE_STATS
|
|
if enabled:
|
|
logger.info("send_usage_stats_report is enabled")
|
|
service = UsageStatsService()
|
|
service.send_usage_stats_report()
|
|
else:
|
|
logger.info("send_usage_stats_report is disabled")
|
|
installation.report_sent_at = timezone.now()
|
|
installation.save()
|
|
logger.info("Finish send_usage_stats_report")
|
|
|
|
|
|
@shared_dedicated_queue_retry_task()
|
|
def send_cloud_heartbeat_task():
|
|
send_cloud_heartbeat()
|
|
|
|
|
|
@shared_dedicated_queue_retry_task()
|
|
def sync_users_with_cloud():
|
|
from apps.oss_installation.models import CloudConnector
|
|
|
|
logger.info("Start sync_users_with_cloud")
|
|
if live_settings.GRAFANA_CLOUD_NOTIFICATIONS_ENABLED:
|
|
connector = CloudConnector.objects.first()
|
|
if connector is not None:
|
|
status, error = connector.sync_users_with_cloud()
|
|
log_message = "Users synced. Status {status}."
|
|
if error:
|
|
log_message += f" Error {error}"
|
|
logger.info(log_message)
|
|
else:
|
|
logger.info("Grafana Cloud is not connected")
|
|
else:
|
|
logger.info("GRAFANA_CLOUD_NOTIFICATIONS_ENABLED is not enabled")
|