centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
oncall-engine/grafana-plugin
History
Joey Orlando b260a8e82b
fix: address RBAC Admin issue (#5087) 
# What this PR does

**NOTE**: should be merged/released after
https://github.com/grafana/irm/pull/183 has been rolled out to most
stacks (as that frontend update is what will grant that new RBAC
"action" to users whom already have the "OnCall Admin" RBAC role
assigned)

tldr; from the comment in the `RBACPermission.Permission.ADMIN` comment
in `engine/apps/api/permissions.py`:

> NOTE: this is a bit of a hack for now. See
https://github.com/grafana/support-escalations/issues/12625
> Basically when it comes to filtering teams that are configured to
share their resources with
> "Team members and admins", we have no way of knowing, when a user is
ACTUALLY an Admin when RBAC is involed.
>
> Example: Take a user with the basic role of None/Editor/Viewer but
with the "OnCall Admin" role assigned.
> Without this RBAC permission, we have no way of knowing that the user
is ACTUALLY an "Admin".

## Which issue(s) this PR closes

Closes https://github.com/grafana/support-escalations/issues/12625

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-09-26 12:40:07 -04:00
..
.config Migrate react-router to v6 (#4703) 2024-07-26 10:36:20 +00:00
e2e-tests ci: update oss plugin release process (#5051) 2024-09-23 11:56:16 -04:00
pkg ci: update oss plugin release process (#5051) 2024-09-23 11:56:16 -04:00
src fix: address RBAC Admin issue (#5087) 2024-09-26 12:40:07 -04:00
tools/eslint-rules address outstanding CVEs + remove plop from grafana-plugin/ (#4871) 2024-08-20 10:29:01 -04:00
.bra.toml [IRM] - changes to get incident working in IRM plugin (#4987) 2024-09-05 17:50:08 +00:00
.dockerignore move ms teams related models, containers, components etc to oncall (#3594) 2024-01-08 10:50:19 +00:00
.eslintignore generate types, create http client and add exemplary usage (#3384) 2023-11-29 05:16:13 +00:00
.eslintrc.js Fixed deprecated imports of H/VGroup in favor of Stack (#4897) 2024-08-27 09:37:30 +00:00
.gitignore chore: Switch to pnpm + adjust to IRM (#4969) 2024-09-02 12:48:23 +00:00
.prettierrc.js Migrate from grafana-toolkit to grafana plugin tools (#3837) 2024-02-21 07:49:10 -07:00
.stylelintrc add selector-max-type stylelint rule 2022-11-02 11:44:42 +00:00
Dockerfile.dev chore: Switch to pnpm + adjust to IRM (#4969) 2024-09-02 12:48:23 +00:00
go.mod [IRM] - changes to get incident working in IRM plugin (#4987) 2024-09-05 17:50:08 +00:00
go.sum New OnCall plugin initialization process (#4657) 2024-08-16 16:43:52 +00:00
jest.config.js fix tests and types generator (#4746) 2024-07-26 15:59:55 +00:00
jest.setup.ts Cleanup error logs on frontend unit test run (#4167) 2024-04-17 11:05:11 +00:00
knip.json Configure knip and remove dead code (#3999) 2024-03-06 08:06:03 +00:00
LICENSE World, meet OnCall! 2022-06-03 08:09:47 -06:00
Magefile.go New OnCall plugin initialization process (#4657) 2024-08-16 16:43:52 +00:00
package.json ci: update oss plugin release process (#5051) 2024-09-23 11:56:16 -04:00
playwright.config.ts test: use 4 workers, disable timezone test (#5044) 2024-09-19 11:25:17 +00:00
pnpm-lock.yaml Rares/v1.6.5 labels (#5042) 2024-09-19 12:03:47 +00:00
README.md move some grafana-plugin/README contents (#3525) 2023-12-08 10:30:01 -05:00
tsconfig.json chore: Switch to pnpm + adjust to IRM (#4969) 2024-09-02 12:48:23 +00:00
webpack.config.ts chore: always point livereload to localhost (#5029) 2024-09-17 15:11:30 +00:00

README.md

Grafana OnCall

Developer-Friendly Alert Management with Brilliant Slack Integration

  • Connect monitoring systems
  • Collect and analyze data
  • On-call rotation
  • Automatic escalation
  • Never miss alerts with calls and SMS

Documentation