oncall-engine/engine/common
Joey Orlando b260a8e82b
fix: address RBAC Admin issue (#5087)
# What this PR does

**NOTE**: should be merged/released after
https://github.com/grafana/irm/pull/183 has been rolled out to most
stacks (as that frontend update is what will grant that new RBAC
"action" to users whom already have the "OnCall Admin" RBAC role
assigned)

tldr; from the comment in the `RBACPermission.Permission.ADMIN` comment
in `engine/apps/api/permissions.py`:

> NOTE: this is a bit of a hack for now. See
https://github.com/grafana/support-escalations/issues/12625
> Basically when it comes to filtering teams that are configured to
share their resources with
> "Team members and admins", we have no way of knowing, when a user is
ACTUALLY an Admin when RBAC is involed.
>
> Example: Take a user with the basic role of None/Editor/Viewer but
with the "OnCall Admin" role assigned.
> Without this RBAC permission, we have no way of knowing that the user
is ACTUALLY an "Admin".

## Which issue(s) this PR closes

Closes https://github.com/grafana/support-escalations/issues/12625

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-09-26 12:40:07 -04:00
..
api_helpers fix: address RBAC Admin issue (#5087) 2024-09-26 12:40:07 -04:00
cloud_auth_api update mobile app proxy's usage of the Cloud Auth API (#4194) 2024-04-11 14:45:21 +00:00
constants Prepare OnCall for Unified Slack App (#4232) 2024-06-03 09:07:10 +00:00
custom_celery_tasks chore: fix some comments (#4055) 2024-03-14 15:36:00 +00:00
exceptions don't force create default user notification policies (#4608) 2024-07-05 15:08:17 -04:00
incident_api Add incident API client (#5040) 2024-09-19 13:35:42 +00:00
insight_log Enable flake8-bugbear, fix issues (#3454) 2023-11-29 15:04:48 +00:00
jinja_templater Add doc references to regex_search jinja filter (#4973) 2024-09-04 17:47:09 +00:00
migrations Add instruction on removing nullable fields from Django models (#2659) 2023-08-08 12:46:18 +00:00
oncall_gateway Prepare OnCall for Unified Slack App (#4232) 2024-06-03 09:07:10 +00:00
ordered_model Update OrderedModel serializer not to save previously updated order (#4706) 2024-07-19 11:56:26 +00:00
recaptcha Add validation of hostname for recapctha (#1445) 2023-03-06 08:59:48 +00:00
tests Add doc references to regex_search jinja filter (#4973) 2024-09-04 17:47:09 +00:00
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
cache.py bump uwsgi to 2.0.26 + Python to 3.12.3 (#4495) 2024-06-10 15:33:37 -04:00
database.py Fix Grafana teams sync (#1652) 2023-03-28 18:26:24 +00:00
l10n.py add user locale field to mobile app user settings table + change going on call push notification text (#2131) 2023-06-14 12:19:58 -04:00
public_primary_keys.py Re-enable a few mypy rules + fix existing errors (#2725) 2023-08-03 09:43:03 +00:00
timezones.py shift swap requests model + CRUD endpoints (#2597) 2023-07-21 19:35:19 +00:00
utils.py Alert group search feature flags (#4579) 2024-07-23 16:12:00 +00:00