# What this PR does * Move declare incident button to first position when incident is acknowledged * Move resolved text above buttons, so buttons remain on the same place when clicked <img width="549" alt="Screenshot 2024-07-09 at 11 52 33 PM" src="https://github.com/grafana/oncall/assets/2262529/68cfb42f-c7ad-42b9-8404-e3400eb70332"> <img width="529" alt="Screenshot 2024-07-09 at 11 52 41 PM" src="https://github.com/grafana/oncall/assets/2262529/d8e36dec-ddfc-4db6-9918-0fb478c1462f"> ## Which issue(s) this PR closes Closes https://github.com/grafana/oncall/issues/1908 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes. --------- Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com> Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
284 lines
10 KiB
Python
284 lines
10 KiB
Python
import json
|
|
|
|
import pytest
|
|
|
|
from apps.alerts.incident_appearance.renderers.slack_renderer import AlertGroupSlackRenderer
|
|
from apps.alerts.models import AlertGroup
|
|
from apps.slack.chatops_proxy_routing import make_value
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_acknowledge_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[0]
|
|
assert button["text"]["text"] == "Acknowledge"
|
|
assert json.loads(button["value"]) == json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
},
|
|
organization,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_unacknowledge_button(
|
|
make_organization, make_alert_receive_channel, make_alert_group, make_alert
|
|
):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel, acknowledged=True)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[1]["blocks"][0]["elements"]
|
|
|
|
button = elements[0]
|
|
assert button["text"]["text"] == "Unacknowledge"
|
|
assert json.loads(button["value"]) == json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
},
|
|
organization,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_resolve_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[1]
|
|
assert button["text"]["text"] == "Resolve"
|
|
assert json.loads(button["value"]) == json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
},
|
|
organization,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_unresolve_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel, resolved=True)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[1]["blocks"][0]["elements"]
|
|
|
|
button = elements[0]
|
|
assert button["text"]["text"] == "Unresolve"
|
|
assert json.loads(button["value"]) == json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
},
|
|
organization,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_responders_button(
|
|
make_organization, make_user, make_alert_receive_channel, make_alert_group, make_alert
|
|
):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[3]
|
|
assert button["text"]["text"] == "Responders"
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_stop_invite_button(
|
|
make_organization, make_user, make_alert_receive_channel, make_alert_group, make_alert, make_invitation
|
|
):
|
|
organization = make_organization()
|
|
user = make_user(organization=organization)
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
invitation = make_invitation(alert_group, user, user)
|
|
|
|
action = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[1]["actions"][0]
|
|
|
|
assert action["text"] == f"Stop inviting {user.username}"
|
|
assert json.loads(action["value"]) == json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
"invitation_id": invitation.pk,
|
|
},
|
|
organization,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_silence_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[2]
|
|
assert button["placeholder"]["text"] == "Silence"
|
|
|
|
values = [json.loads(option["value"]) for option in button["options"]]
|
|
assert values == [
|
|
json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
"delay": delay,
|
|
},
|
|
organization,
|
|
)
|
|
)
|
|
for delay, _ in AlertGroup.SILENCE_DELAY_OPTIONS
|
|
]
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_unsilence_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel, silenced=True)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
button = elements[2]
|
|
|
|
assert button["text"]["text"] == "Unsilence"
|
|
assert json.loads(button["value"]) == json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
},
|
|
organization,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_attach_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel, silenced=True)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
button = elements[4]
|
|
|
|
assert button["text"]["text"] == "Attach to ..."
|
|
assert json.loads(button["value"]) == json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
},
|
|
organization,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_unattach_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
|
|
root_alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=root_alert_group, raw_request_data={})
|
|
|
|
alert_group = make_alert_group(alert_receive_channel, root_alert_group=root_alert_group)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
action = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["actions"][0]
|
|
|
|
assert action["text"] == "Unattach"
|
|
assert json.loads(action["value"]) == json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
},
|
|
organization,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_format_alert_button(
|
|
make_organization, make_alert_receive_channel, make_alert_group, make_alert
|
|
):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[5]
|
|
assert button["text"]["text"] == ":mag: Format Alert"
|
|
assert json.loads(button["value"]) == json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
},
|
|
organization,
|
|
)
|
|
)
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_resolution_notes_button(
|
|
make_organization, make_alert_receive_channel, make_alert_group, make_alert
|
|
):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[6]
|
|
assert button["text"]["text"] == "Add Resolution notes"
|
|
assert json.loads(button["value"]) == json.loads(
|
|
make_value(
|
|
{
|
|
"organization_id": organization.pk,
|
|
"alert_group_ppk": alert_group.public_primary_key,
|
|
"resolution_note_window_action": "edit",
|
|
},
|
|
organization,
|
|
)
|
|
)
|