06933a696a
# What this PR does This PR adds support for routing alerts based on labels. https://www.loom.com/share/4401de6e3c4945d5b8961fe43ee373c9 Additionally: - improve the typing around the `get_object` method that is inherited by [`PublicPrimaryKeyMixin.get_object`](https://github.com/grafana/oncall/blob/dev/engine/common/api_helpers/mixins.py#L153) in most of our models. `PublicPrimaryKeyMixin` is generic, so it can be more strongly typed when it is being subclassed, which results in better typing of the `get_object` method in child classes - I decided to do this because I started looking into this task via the [`AlertReceiveChannelView.send_demo_alert` method/endpoint](https://github.com/grafana/oncall/blob/dev/engine/apps/api/views/alert_receive_channel.py#L242). Within that method, `instance` is not typed because the inherited `get_object` method is not typed.. I digress 😄 - improve typing around `Alert.create` and `apps.integrations.tasks.create_alert` functions - make `Alert.render_group_data` more DRY by extracting some logic out into `Alert._apply_jinja_template_to_alert_payload_and_labels` - deduplicate the logic of `value.strip().lower() in ["1", "true", "ok"]` into a shared function, `common.jinja_templater.apply_jinja_template.templated_value_is_truthy` Closes https://github.com/grafana/oncall-private/issues/2490 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) - [x] Documentation added (or `pr:no public docs` PR label added if not required) (will be done in #3762)
40 lines
1.4 KiB
Python
40 lines
1.4 KiB
Python
from rest_framework import mixins
|
|
from rest_framework.filters import SearchFilter
|
|
from rest_framework.permissions import IsAuthenticated
|
|
from rest_framework.viewsets import GenericViewSet
|
|
|
|
from apps.api.permissions import RBACPermission
|
|
from apps.api.serializers.slack_channel import SlackChannelSerializer
|
|
from apps.auth_token.auth import PluginAuthentication
|
|
from apps.slack.models import SlackChannel
|
|
from common.api_helpers.mixins import PublicPrimaryKeyMixin
|
|
from common.api_helpers.paginators import HundredPageSizePaginator
|
|
|
|
|
|
class SlackChannelView(
|
|
PublicPrimaryKeyMixin[SlackChannel], mixins.ListModelMixin, mixins.RetrieveModelMixin, GenericViewSet
|
|
):
|
|
authentication_classes = (PluginAuthentication,)
|
|
permission_classes = (IsAuthenticated, RBACPermission)
|
|
|
|
pagination_class = HundredPageSizePaginator
|
|
|
|
model = SlackChannel
|
|
filter_backends = (SearchFilter,)
|
|
serializer_class = SlackChannelSerializer
|
|
search_fields = ["name"]
|
|
|
|
rbac_permissions = {
|
|
"list": [RBACPermission.Permissions.CHATOPS_READ],
|
|
"retrieve": [RBACPermission.Permissions.CHATOPS_READ],
|
|
}
|
|
|
|
def get_queryset(self):
|
|
organization = self.request.auth.organization
|
|
slack_team_identity = organization.slack_team_identity
|
|
queryset = SlackChannel.objects.filter(
|
|
slack_team_identity=slack_team_identity,
|
|
is_archived=False,
|
|
)
|
|
|
|
return queryset.order_by("id")
|