a991fac43e
This pull request updates multiple GitHub Actions workflows to improve security, stability, and functionality. The most notable changes include pinning action versions to specific commit SHAs, adding validation for branch names, and updating dependencies and configurations. ### Security Improvements: * Added `persist-credentials: false` to `actions/checkout` steps in `.github/workflows/build-engine-docker-image-and-publish-to-dockerhub.yml` and `.github/workflows/e2e-tests.yml` to reduce the risk of unauthorized access to credentials. [[1]](diffhunk://#diff-f87667d48e22abfbbccf3695a8acc386143e3542286f432e6e3d8330960c76f9R29) [[2]](diffhunk://#diff-194218c48b9a0cdd03974145733804c2d992ca818529fe2fa69a501d8b5b1cc3R48-R59) * Validated branch names against a safe pattern in `.github/workflows/linting-and-tests.yml` to prevent potential misuse of branch names in subsequent steps. ### Stability Enhancements: * Pinned all third-party GitHub Actions to specific commit SHAs across various workflows to ensure consistent and predictable behavior. Examples include `grafana/shared-workflows/actions/build-push-to-dockerhub`, `catchpoint/workflow-telemetry-action`, and `actions-ecosystem/action-remove-labels`. [[1]](diffhunk://#diff-f87667d48e22abfbbccf3695a8acc386143e3542286f432e6e3d8330960c76f9L37-R38) [[2]](diffhunk://#diff-194218c48b9a0cdd03974145733804c2d992ca818529fe2fa69a501d8b5b1cc3R48-R59) [[3]](diffhunk://#diff-f93a3de9563193d65121683e6383741ac4b6aa18bdb51ba82b80497e700561cdL15-R15) * Updated Helm-related actions in `.github/workflows/linting-and-tests.yml` and `.github/workflows/on-release-published.yml` to specific SHAs for better reliability. [[1]](diffhunk://#diff-a70d3d29c45894eeef2036c533385dbc424f9479590aaea01e62c06dc67079a1L147-R170) [[2]](diffhunk://#diff-e95a5d3f03a1351728732657b6b150cfbbd9a9724b387226b1f99f079b1954b0L91-R91) ### Functional Updates: * Enhanced `.github/workflows/linting-and-tests.yml` by using validated branch references in Git commands to avoid errors caused by unsafe branch names. * Updated `snyk/actions/setup` in `.github/workflows/snyk-security-scan.yml` to a specific SHA for improved compatibility and security. These changes collectively enhance the security, reliability, and maintainability of the workflows.
48 lines
1.7 KiB
YAML
48 lines
1.7 KiB
YAML
name: Build engine Docker image and publish to Dockerhub
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
engine_version:
|
|
required: false
|
|
type: string
|
|
docker_image_tags:
|
|
required: true
|
|
type: string
|
|
|
|
jobs:
|
|
build-engine-docker-image-and-publish-to-dockerhub:
|
|
name: Build engine Docker image and publish to Dockerhub
|
|
runs-on: ubuntu-latest-16-cores
|
|
# These permissions are needed to assume roles from Github's OIDC.
|
|
# https://github.com/grafana/shared-workflows/tree/main/actions/build-push-to-dockerhub
|
|
permissions:
|
|
contents: read
|
|
id-token: write
|
|
steps:
|
|
- name: Checkout project
|
|
uses: actions/checkout@v4
|
|
with:
|
|
# we have one large .whl file which is referenced in the engine Dockerfile.. we need to
|
|
# fetch that file to be able to properly build the image
|
|
lfs: true
|
|
persist-credentials: false
|
|
- name: Set engine version number in settings file
|
|
if: inputs.engine_version
|
|
uses: ./.github/actions/set-engine-version-in-settings
|
|
with:
|
|
working_directory: .
|
|
engine_version_number: ${{ inputs.engine_version }}
|
|
settings_file_path: engine/settings/base.py
|
|
- name: Build engine Docker image and push to Dockerhub
|
|
uses: grafana/shared-workflows/actions/build-push-to-dockerhub@b7d33d6a98dc9cf332674c6cdebe92b8bcb05670 #v0.3.0
|
|
with:
|
|
context: engine/
|
|
push: true
|
|
platforms: linux/arm64/v8,linux/amd64
|
|
repository: grafana/oncall
|
|
tags: ${{ inputs.docker_image_tags }}
|
|
build-args: |
|
|
BUILDKIT_INLINE_CACHE=1
|
|
target: prod
|
|
cache-from: grafana/oncall:latest
|