a936c8c7fe
# What this PR does Before: <img width="281" alt="Screenshot 2023-03-23 at 16 56 42" src="https://user-images.githubusercontent.com/20116910/227279464-c883ec05-a964-4360-bda2-3443409ca90a.png"> After: <img width="338" alt="Screenshot 2023-03-23 at 16 57 41" src="https://user-images.githubusercontent.com/20116910/227279476-468bffba-922a-45ea-b400-5f34d6bf0534.png"> - Add scores for overloaded users, e.g. `(+25% avg)` which means the user is scheduled to be on-call 25% more than average for given schedule. - Add score for gaps, e.g. `Schedule has gaps (29% not covered)` which means 29% of time no one is scheduled to be on-call. - Make things easier to understand when there are gaps in the schedule, add `(see overloaded users)` text. - Consider events for next 52 weeks (~1 year) instead of 90 days (~3 months), so the quality report is more accurate. Also treat any balance quality >95% as perfectly balanced. These two changes (period change and adding 95% threshold) should help eliminate false positives for _most_ schedules. - Modify backend & frontend so the backend returns all necessary user information to render without using the user store. - Move quality report generation to `OnCallSchedule` model, add more tests. ## Which issue(s) this PR fixes Related to https://github.com/grafana/oncall/issues/1552 ## Checklist - [x] Tests updated - [x] `CHANGELOG.md` updated (public docs will be added in a separate PR)
19 lines
933 B
TypeScript
19 lines
933 B
TypeScript
import { test, expect } from '@playwright/test';
|
|
import { configureOnCallPlugin } from '../utils/configurePlugin';
|
|
import { generateRandomValue } from '../utils/forms';
|
|
import { createOnCallSchedule } from '../utils/schedule';
|
|
|
|
test.beforeEach(async ({ page }) => {
|
|
await configureOnCallPlugin(page);
|
|
});
|
|
|
|
test('check schedule quality for simple 1-user schedule', async ({ page }) => {
|
|
const onCallScheduleName = generateRandomValue();
|
|
await createOnCallSchedule(page, onCallScheduleName);
|
|
|
|
await expect(page.locator('div[class*="ScheduleQuality"]')).toHaveText('Quality: Great');
|
|
|
|
await page.hover('div[class*="ScheduleQuality"]');
|
|
await expect(page.locator('div[class*="ScheduleQualityDetails"] >> span[class*="Text"] >> nth=2 ')).toHaveText('Schedule has no gaps');
|
|
await expect(page.locator('div[class*="ScheduleQualityDetails"] >> span[class*="Text"] >> nth=3 ')).toHaveText('Schedule is perfectly balanced');
|
|
});
|