oncall-engine/engine/apps/alerts/models
Joey Orlando a29e35c25a
refactor SlackMessage.channel_id (CHAR field) to SlackMessage.channel (foreign key relationship) (#5292)
# What this PR does

Related to https://github.com/grafana/oncall-private/issues/2947

**NOTE**

This PR introduces steps 1 and 2 of the 3 part migration proposed
[here](https://raintank-corp.slack.com/archives/C06K1MQ07GS/p1732555465144099).
Step 3, swapping reads to be from the new-column and dropping
dual-writes, will be done in a future PR/release.

---

I’m tackling this work now because _ultimately_ I want to move
`AlertReceiveChannel.rate_limited_in_slack_at` to
`SlackChannel.rate_limited_at` , but first I sorta need to refactor
`SlackMessage.channel_id` from a `CHAR` field to a foreign key
relationship (because in the spots where we touch Slack rate limiting,
like
[here](https://github.com/grafana/oncall/blob/dev/engine/apps/slack/alert_group_slack_service.py#L42-L50)
for example, we only have `slack_message.channel_id`, which means I need
to do extra queries to fetch the appropriate `SlackChannel` to then be
able to get/set `SlackChannel.rate_limited_at`

Other minor stuffs:
- it also prepares us to drop `SlackMessage._slack_team_identity`. We
already have a `@property` of `SlackMessage.slack_team_identity` (which
[previously had some hacky
logic](https://github.com/grafana/oncall/blob/dev/engine/apps/slack/models/slack_message.py#L74-L84)).
I've refactored `SlackMessage.slack_team_identity` to simply point to
`self.organization.slack_team_identity` + updated our code to _stop_
setting `SlackMessage._slack_team_identity` (will drop this column in
future release)

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-11-26 11:03:38 +00:00
..
__init__.py Reworked declare incident escalation step (#5130) 2024-10-07 19:26:10 +00:00
alert.py remove deprecate_field usage (#5148) 2024-10-09 21:46:38 +00:00
alert_group.py refactor SlackMessage.channel_id (CHAR field) to SlackMessage.channel (foreign key relationship) (#5292) 2024-11-26 11:03:38 +00:00
alert_group_counter.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
alert_group_log_record.py Reworked declare incident escalation step (#5130) 2024-10-07 19:26:10 +00:00
alert_manager_models.py Enable flake8-bugbear, fix issues (#3454) 2023-11-29 15:04:48 +00:00
alert_receive_channel.py chore: remove deprecated slack_channel and heartbeat integration types (#5270) 2024-11-20 11:17:04 -05:00
alert_receive_channel_connection.py SNOW external ID (#4076) 2024-03-20 10:54:27 +00:00
channel_filter.py chore: remove deprecated AlertGroupPostMortem model + recently refactored/deprecated slack channel related columns (#5240) 2024-11-19 19:23:48 +00:00
custom_button.py cleanup CustomButton backend code + add ngrok/express outgoing webhook e2e test (#2544) 2024-03-28 15:37:22 +00:00
escalation_chain.py re-enable mypy GitHub Actions CI job (#2390) 2023-06-29 14:01:52 +00:00
escalation_policy.py Add openAPI schema for some internal endpoints (#5037) 2024-10-24 09:24:36 +00:00
grafana_alerting_contact_point.py Improve getting/updating contact points for Grafana Alerting integration (#2742) 2023-08-18 12:12:29 +02:00
invitation.py chore: convert two slack channel ID char fields to foreign keys (#5224) 2024-11-04 13:34:06 -05:00
maintainable_object.py Improve OpenAPI schema coverage (#3629) 2024-01-12 15:11:22 +00:00
related_incident.py Reworked declare incident escalation step (#5130) 2024-10-07 19:26:10 +00:00
resolution_note.py chore: remove deprecated AlertGroupPostMortem model + recently refactored/deprecated slack channel related columns (#5240) 2024-11-19 19:23:48 +00:00
user_has_notification.py User notifications bundle (#4457) 2024-07-16 11:24:08 +00:00
user_notification_bundle.py Fix notification plan builder (#4726) 2024-07-24 15:49:03 +00:00