oncall-engine/engine/apps/email
Joey Orlando 34a90134fb
patch default user notification policy changes + fix failing e2e test (#4635)
# What this PR does

This is a follow-up PR to https://github.com/grafana/oncall/pull/4628.
As @Ferril pointed out, there was a slight issue in
`apps.alerts.tasks.notify_user.perform_notification` method when using a
"fallback"/default user notification policy. This is because the
`log_record_pk` arg passed into `perform_notification` will fetch the
`UserNotificationPolicyLogRecord` object, but that object will have a
`notification_policy` set to `None` (because there's no persistent
`UserNotificationPolicy` object to refer to).

Instead we now pass in a second argument to `perform_notification`,
`use_default_notification_policy_fallback`. If this is true, simply grab
the transient/in-memory `UserNotificationPolicy` and use that inside of
this task

Related to https://github.com/grafana/oncall/issues/4410

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-07-09 11:23:53 -04:00
..
migrations Change email message on_delete to not block organization delete (#2060) 2023-05-31 13:44:55 +00:00
templates Change email templating to not wrap user defined templates (#3862) 2024-02-09 19:03:25 +00:00
tests Change email templating to not wrap user defined templates (#3862) 2024-02-09 19:03:25 +00:00
__init__.py Restore email notifications (#621) 2022-10-19 12:32:56 +01:00
alert_rendering.py Change email templating to not wrap user defined templates (#3862) 2024-02-09 19:03:25 +00:00
backend.py patch default user notification policy changes + fix failing e2e test (#4635) 2024-07-09 11:23:53 -04:00
inbound.py Handle unexpected recipient value. Add logging. (#4626) 2024-07-08 14:02:32 +00:00
models.py Change email message on_delete to not block organization delete (#2060) 2023-05-31 13:44:55 +00:00
tasks.py patch default user notification policy changes + fix failing e2e test (#4635) 2024-07-09 11:23:53 -04:00