06933a696a
# What this PR does This PR adds support for routing alerts based on labels. https://www.loom.com/share/4401de6e3c4945d5b8961fe43ee373c9 Additionally: - improve the typing around the `get_object` method that is inherited by [`PublicPrimaryKeyMixin.get_object`](https://github.com/grafana/oncall/blob/dev/engine/common/api_helpers/mixins.py#L153) in most of our models. `PublicPrimaryKeyMixin` is generic, so it can be more strongly typed when it is being subclassed, which results in better typing of the `get_object` method in child classes - I decided to do this because I started looking into this task via the [`AlertReceiveChannelView.send_demo_alert` method/endpoint](https://github.com/grafana/oncall/blob/dev/engine/apps/api/views/alert_receive_channel.py#L242). Within that method, `instance` is not typed because the inherited `get_object` method is not typed.. I digress 😄 - improve typing around `Alert.create` and `apps.integrations.tasks.create_alert` functions - make `Alert.render_group_data` more DRY by extracting some logic out into `Alert._apply_jinja_template_to_alert_payload_and_labels` - deduplicate the logic of `value.strip().lower() in ["1", "true", "ok"]` into a shared function, `common.jinja_templater.apply_jinja_template.templated_value_is_truthy` Closes https://github.com/grafana/oncall-private/issues/2490 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) - [x] Documentation added (or `pr:no public docs` PR label added if not required) (will be done in #3762)
82 lines
3.4 KiB
Python
82 lines
3.4 KiB
Python
from rest_framework import mixins, viewsets
|
|
from rest_framework.decorators import action
|
|
from rest_framework.permissions import IsAuthenticated
|
|
from rest_framework.response import Response
|
|
|
|
from apps.api.permissions import RBACPermission
|
|
from apps.api.serializers.integration_heartbeat import IntegrationHeartBeatSerializer
|
|
from apps.auth_token.auth import PluginAuthentication
|
|
from apps.heartbeat.models import IntegrationHeartBeat
|
|
from common.api_helpers.mixins import PublicPrimaryKeyMixin, TeamFilteringMixin
|
|
from common.insight_log import EntityEvent, write_resource_insight_log
|
|
|
|
|
|
class IntegrationHeartBeatView(
|
|
TeamFilteringMixin,
|
|
PublicPrimaryKeyMixin[IntegrationHeartBeat],
|
|
mixins.RetrieveModelMixin,
|
|
mixins.ListModelMixin,
|
|
mixins.CreateModelMixin,
|
|
mixins.UpdateModelMixin,
|
|
viewsets.GenericViewSet,
|
|
):
|
|
authentication_classes = (PluginAuthentication,)
|
|
permission_classes = (IsAuthenticated, RBACPermission)
|
|
rbac_permissions = {
|
|
"metadata": [RBACPermission.Permissions.INTEGRATIONS_READ],
|
|
"list": [RBACPermission.Permissions.INTEGRATIONS_READ],
|
|
"retrieve": [RBACPermission.Permissions.INTEGRATIONS_READ],
|
|
"timeout_options": [RBACPermission.Permissions.INTEGRATIONS_READ],
|
|
"create": [RBACPermission.Permissions.INTEGRATIONS_WRITE],
|
|
"update": [RBACPermission.Permissions.INTEGRATIONS_WRITE],
|
|
"partial_update": [RBACPermission.Permissions.INTEGRATIONS_WRITE],
|
|
"activate": [RBACPermission.Permissions.INTEGRATIONS_WRITE],
|
|
"deactivate": [RBACPermission.Permissions.INTEGRATIONS_WRITE],
|
|
}
|
|
|
|
model = IntegrationHeartBeat
|
|
serializer_class = IntegrationHeartBeatSerializer
|
|
|
|
TEAM_LOOKUP = "alert_receive_channel__team"
|
|
|
|
def get_queryset(self, ignore_filtering_by_available_teams=False):
|
|
alert_receive_channel_id = self.request.query_params.get("alert_receive_channel", None)
|
|
lookup_kwargs = {}
|
|
if alert_receive_channel_id:
|
|
lookup_kwargs = {"alert_receive_channel__public_primary_key": alert_receive_channel_id}
|
|
queryset = IntegrationHeartBeat.objects.filter(
|
|
alert_receive_channel__organization=self.request.auth.organization,
|
|
**lookup_kwargs,
|
|
)
|
|
if not ignore_filtering_by_available_teams:
|
|
queryset = queryset.filter(*self.available_teams_lookup_args).distinct()
|
|
queryset = self.serializer_class.setup_eager_loading(queryset)
|
|
return queryset
|
|
|
|
def perform_create(self, serializer):
|
|
serializer.save()
|
|
instance = serializer.instance
|
|
write_resource_insight_log(
|
|
instance=instance,
|
|
author=self.request.user,
|
|
event=EntityEvent.CREATED,
|
|
)
|
|
|
|
def perform_update(self, serializer):
|
|
prev_state = serializer.instance.insight_logs_serialized
|
|
serializer.save()
|
|
new_state = serializer.instance.insight_logs_serialized
|
|
write_resource_insight_log(
|
|
instance=serializer.instance,
|
|
author=self.request.user,
|
|
event=EntityEvent.UPDATED,
|
|
prev_state=prev_state,
|
|
new_state=new_state,
|
|
)
|
|
|
|
@action(detail=False, methods=["get"])
|
|
def timeout_options(self, request):
|
|
choices = []
|
|
for item in IntegrationHeartBeat.TIMEOUT_CHOICES:
|
|
choices.append({"value": item[0], "display_name": item[1]})
|
|
return Response(choices)
|