oncall-engine/engine/apps/slack
Joey Orlando 26946f0d43
fix: improve Slack rate limiting logic when updating alert groups (#5287)
# What this PR does

https://www.loom.com/share/1ac33822301444748133ffe72638ddc4

The two asks in the [original GH
issue](https://github.com/grafana/oncall-private/issues/2947) were:

> 1. Make the error message clearer. We can identify if it's delivering
or updating and being rate-limited. This is possible because Slack sets
limits per API method. Also, this limit is a per-slack channel while we
are posting messages & applying ratelimit per on-call integration, which
confuses customers.
> 2. Debounce update alert group message in Slack

Both of these have been addressed in this PR

## Which issue(s) this PR closes

Closes https://github.com/grafana/oncall-private/issues/2947

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-12-02 14:40:30 -05:00
..
migrations fix: improve Slack rate limiting logic when updating alert groups (#5287) 2024-12-02 14:40:30 -05:00
models fix: improve Slack rate limiting logic when updating alert groups (#5287) 2024-12-02 14:40:30 -05:00
representatives chore: random slack code cleanup (#5307) 2024-11-29 13:21:29 +00:00
scenarios fix: improve Slack rate limiting logic when updating alert groups (#5287) 2024-12-02 14:40:30 -05:00
tests fix: improve Slack rate limiting logic when updating alert groups (#5287) 2024-12-02 14:40:30 -05:00
types Introduce slash command matcher (#4717) 2024-07-24 09:53:06 +00:00
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
alert_group_slack_service.py fix: improve Slack rate limiting logic when updating alert groups (#5287) 2024-12-02 14:40:30 -05:00
chatops_proxy_routing.py Prepare OnCall for Unified Slack App (#4232) 2024-06-03 09:07:10 +00:00
client.py Update when slack client ratelimit retry handler is enabled (#3447) 2023-11-30 12:35:46 +00:00
constants.py fix: improve Slack rate limiting logic when updating alert groups (#5287) 2024-12-02 14:40:30 -05:00
errors.py Update Slack user group for a schedule - handle paid_team_only Slack API error (#4793) 2024-08-09 14:51:01 +00:00
installation.py Unified Slack app reinstall (#4682) 2024-07-19 11:53:06 +00:00
slack_formatter.py Fix alert group rendering (#3424) 2023-11-24 15:39:37 +00:00
slash_command.py Make root command configurable (#4863) 2024-08-21 06:54:47 +00:00
tasks.py fix: improve Slack rate limiting logic when updating alert groups (#5287) 2024-12-02 14:40:30 -05:00
urls.py Make Slack URLs work without trailing slashes (#4607) 2024-07-03 15:55:54 +00:00
utils.py fix: improve Slack rate limiting logic when updating alert groups (#5287) 2024-12-02 14:40:30 -05:00
views.py refactor SlackMessage.channel_id (CHAR field) to SlackMessage.channel (foreign key relationship) (#5292) 2024-11-26 11:03:38 +00:00