centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
oncall-engine/engine/apps
History
Joey Orlando 72e7224ad3
do not retry firebase.messaging.UnregisteredError exceptions for FCM relay tasks (#3637) 
# What this PR does

_tldr_; we had a lengthy discussion about this
[here](https://raintank-corp.slack.com/archives/C04JCU51NF8/p1701893410542629?thread_ts=1701690117.016909&cid=C04JCU51NF8).
`firebase.messaging.UnregisteredError` errors occur because of events
outside of our control and retrying will never fix them, therefore we
should simply skip retrying in this case.

We retry these fairly often
([logs](https://ops.grafana-ops.net/explore?schemaVersion=1&panes=%7B%22iWZ%22:%7B%22datasource%22:%22000000193%22,%22queries%22:%5B%7B%22refId%22:%22A%22,%22expr%22:%22%23%20%7Bcluster%3D~%5C%22prod-%28eu-west-0%7Cus-central-0%29%5C%22,%20namespace%3D%5C%22amixr-prod%5C%22%7D%20%7C%3D%20%5C%22task_name%3Dapps.webhooks.tasks.trigger_webhook.execute_webhook%5C%22%20%7C%3D%20%5C%22retry%5C%22%5Cn%7Bcluster%3D~%5C%22prod-%28eu-west-0%7Cus-central-0%29%5C%22,%20namespace%3D%5C%22amixr-prod%5C%22%7D%20%7C%3D%20%5C%22apps.mobile_app.fcm_relay.fcm_relay_async%5C%22%20%7C%3D%20%5C%22UnregisteredError%5C%22%22,%22queryType%22:%22range%22,%22datasource%22:%7B%22type%22:%22loki%22,%22uid%22:%22000000193%22%7D,%22editorMode%22:%22code%22%7D%5D,%22range%22:%7B%22from%22:%22now-7d%22,%22to%22:%22now%22%7D%7D%7D&orgId=1))
which eats up unnecessary celery worker resources.

Related to https://github.com/grafana/oncall-private/issues/1820

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2024-01-09 08:14:20 -05:00
..
alerts Update auditor to check personal notifications (#3563) 2023-12-18 16:13:18 +00:00
api Let mobile use paging endpoint (#3619) 2024-01-08 12:18:39 +00:00
api_for_grafana_incident Add render_for_web information to alert group incident API (#3005) 2023-09-12 12:02:42 +00:00
auth_token Change service account auth to use instance id instead (#3435) 2023-11-28 15:56:29 +00:00
base Create log record for telegram formatting error in notification (#3628) 2024-01-08 20:12:28 +00:00
email Fix inbound email integration endpoint (#3586) 2023-12-20 08:40:47 -05:00
grafana_plugin Mobile app proxy gateway (#3449) 2023-12-05 19:58:05 +00:00
heartbeat Track alert received timestamp on alert group creation (#3513) 2023-12-06 12:20:03 +00:00
integrations Fix posting slack message about ratelimits (#3582) 2023-12-19 06:05:57 +00:00
labels Limit the number of labels per alert group (#3507) 2023-12-08 10:34:25 +00:00
metrics_exporter address issue with metrics calculations when redis cluster is used (#3510) 2023-12-05 12:12:08 -05:00
mobile_app do not retry firebase.messaging.UnregisteredError exceptions for FCM relay tasks (#3637) 2024-01-09 08:14:20 -05:00
oss_installation Revert "upgrade to Python 3.12 (#3456)" and "bump uwsgi version to latest #3466" (#3483) 2023-12-01 09:56:26 -05:00
phone_notifications Revert "upgrade to Python 3.12 (#3456)" and "bump uwsgi version to latest #3466" (#3483) 2023-12-01 09:56:26 -05:00
public_api fix PUT /api/v1/escalation_policies/<id> issue related to updating from_time and to_time (#3581) 2023-12-19 09:13:07 -05:00
schedules patch redis cluster multi-key operations (#3496) 2023-12-04 13:08:57 -05:00
slack fix duplicate teams showing up in teams dropdown for /escalate slack command (#3590) 2023-12-22 12:36:54 +00:00
social_auth Enable flake8-bugbear, fix issues (#3454) 2023-11-29 15:04:48 +00:00
telegram Create log record for telegram formatting error in notification (#3628) 2024-01-08 20:12:28 +00:00
twilioapp add missing db migrations + add additional backend db migration check to CI (#3234) 2023-10-31 16:00:55 -04:00
user_management Setup one-at-a-time lock for sync_organization tasks (#3612) 2024-01-04 15:34:28 +00:00
webhooks manually retry for requests.exceptions.Timeout exceptions when sending outgoing webhooks (#3632) 2024-01-08 19:13:15 -05:00
zvonok add missing db migrations + add additional backend db migration check to CI (#3234) 2023-10-31 16:00:55 -04:00
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00