oncall-engine/engine/apps/grafana_plugin/tests/test_sync.py
Michael Derynck 2c7ebcf87c
Add task to delete empty deleted integrations from the database (#3941)
# What this PR does
Add task which will cleanup deleted integrations from the database if
they don't have any alert groups. This is to help address an issue where
queries are slowing down due to having a large numbers of ids that do
not contribute to the result.

This will be connected as part of sync organization task once it tests
out ok.

## Which issue(s) this PR fixes

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2024-02-27 17:34:41 +00:00

165 lines
6.1 KiB
Python

from unittest.mock import patch
import pytest
from django.conf import settings
from django.test.utils import override_settings
from django.utils import timezone
from apps.alerts.models import AlertReceiveChannel
from apps.grafana_plugin.tasks.sync import cleanup_empty_deleted_integrations, run_organization_sync
class SyncOrganization(object):
called = False
org = None
def do_sync_organization(self, org):
self.called = True
self.org = org
def reset(self):
self.called = False
self.org = None
class TestGcomAPIClient:
called = False
info = None
status = None
STACK_STATUS_ACTIVE = "active"
def reset(self):
self.called = False
self.info = None
self.status = None
def set_info(self, info):
self.info = info
def set_status(self, status):
self.status = status
def get_instance_info(self, stack_id: str):
self.called = True
return self.info
@pytest.mark.django_db
def test_sync_organization_skip(
make_organization,
make_token_for_organization,
):
organization = make_organization()
syncer = SyncOrganization()
with patch("apps.grafana_plugin.tasks.sync.sync_organization", new=lambda org: syncer.do_sync_organization(org)):
run_organization_sync(organization.id, True) # Call for existing org (forced)
assert syncer.called and syncer.org == organization
syncer.reset()
run_organization_sync(123321, True) # Not called for non-existing org
assert not syncer.called and not syncer.org
syncer.reset()
run_organization_sync(organization.id, False) # Call for new org
assert syncer.called and syncer.org == organization
syncer.reset()
organization.last_time_synced = timezone.now()
organization.save(update_fields=["last_time_synced"])
run_organization_sync(organization.id, False) # Not called for recently synced org
assert not syncer.called and not syncer.org
syncer.reset()
@override_settings(GRAFANA_COM_API_TOKEN="TestGrafanaComToken")
@override_settings(LICENSE=settings.CLOUD_LICENSE_NAME)
@pytest.mark.django_db
def test_sync_organization_skip_cloud(
make_organization,
make_token_for_organization,
):
organization = make_organization()
syncer = SyncOrganization()
test_client = TestGcomAPIClient()
with patch("apps.grafana_plugin.tasks.sync.sync_organization", new=lambda org: syncer.do_sync_organization(org)):
with patch("apps.grafana_plugin.tasks.sync.GcomAPIClient", new=lambda api_token: test_client):
test_client.info = {"status": "active"}
run_organization_sync(organization.id, False) # Called since instance info is active in cloud
assert test_client.called and syncer.called and syncer.org == organization
syncer.reset()
test_client.reset()
test_client.info = {"status": "paused"}
run_organization_sync(organization.id, False) # Not called since status != active in cloud
assert test_client.called and not syncer.called and not syncer.org
syncer.reset()
test_client.reset()
run_organization_sync(organization.id, False) # Not called since status was none in cloud
assert test_client.called and not syncer.called and not syncer.org
syncer.reset()
test_client.reset()
def create_test_integrations_for_cleanup(make_organization, make_alert_receive_channel, make_alert_group):
org = make_organization()
org_channel = make_alert_receive_channel(organization=org)
org_channel_empty = make_alert_receive_channel(organization=org)
org_channel_deleted = make_alert_receive_channel(organization=org)
org_channel_deleted_empty = make_alert_receive_channel(organization=org)
make_alert_group(alert_receive_channel=org_channel)
make_alert_group(alert_receive_channel=org_channel_deleted)
org_channel_deleted.delete()
org_channel_deleted_empty.delete()
return org, org_channel, org_channel_empty, org_channel_deleted, org_channel_deleted_empty
@pytest.mark.django_db
@pytest.mark.parametrize(
"dry_run, channel1_exists, channel2_exists, channel3_exists, channel4_exists",
[
(True, True, True, True, True),
(False, True, True, True, False),
],
)
def test_cleanup_empty_deleted_integrations_test_run(
make_organization,
make_alert_receive_channel,
make_alert_group,
dry_run,
channel1_exists,
channel2_exists,
channel3_exists,
channel4_exists,
):
(
org1,
org1_channel,
org1_channel_empty,
org1_channel_deleted,
org1_channel_deleted_empty,
) = create_test_integrations_for_cleanup(make_organization, make_alert_receive_channel, make_alert_group)
(
org2,
org2_channel,
org2_channel_empty,
org2_channel_deleted,
org2_channel_deleted_empty,
) = create_test_integrations_for_cleanup(make_organization, make_alert_receive_channel, make_alert_group)
assert AlertReceiveChannel.objects_with_deleted.filter(organization=org1).count() == 4
assert AlertReceiveChannel.objects_with_deleted.filter(organization=org2).count() == 4
cleanup_empty_deleted_integrations(org1.pk, dry_run)
assert AlertReceiveChannel.objects_with_deleted.filter(pk=org1_channel.pk).exists() == channel1_exists
assert AlertReceiveChannel.objects_with_deleted.filter(pk=org1_channel_empty.pk).exists() == channel2_exists
assert AlertReceiveChannel.objects_with_deleted.filter(pk=org1_channel_deleted.pk).exists() == channel3_exists
assert AlertReceiveChannel.objects_with_deleted.filter(pk=org1_channel_deleted_empty.pk).exists() == channel4_exists
# Org 2 should always be unaffected
assert AlertReceiveChannel.objects_with_deleted.filter(pk=org2_channel.pk).exists()
assert AlertReceiveChannel.objects_with_deleted.filter(pk=org2_channel_empty.pk).exists()
assert AlertReceiveChannel.objects_with_deleted.filter(pk=org2_channel_deleted.pk).exists()
assert AlertReceiveChannel.objects_with_deleted.filter(pk=org2_channel_deleted_empty.pk).exists()