centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
oncall-engine/engine/apps/public_api/serializers
History
Vadim Stepanov 602ed535e3
Fix duplicate orders on routes and escalation policies (#2568) 
# What this PR does

Fix duplicate `order` values for models `EscalationPolicy` and
`ChannelFilter` using the same approach as
https://github.com/grafana/oncall/pull/2278.

- Make internal API action `move_to_position` a part of
[OrderedModelViewSet](https://github.com/grafana/oncall/pull/2568/files#diff-eb62521ccbcb072d1bd2156adeadae3b5895bce6d0d54432a23db3948b0ada54R11-R34),
so all ordered model views use the same logic.
- Make public API serializers for ordered models inherit from
[OrderedModelSerializer](https://github.com/grafana/oncall/pull/2568/files#diff-d749f94af5a49adaf5074325cdfad10ddd5a52dbfd78b49582867ebb9c92fae5R6-R38),
so ordered model views are consistent with each other in public API.
- Remove `order` from plugin fronted, since it's not being used
anywhere. The frontend uses step indices & `move_to_position` action
instead.
- Make escalation snapshot use step indices instead of orders, since
orders are not guaranteed to be sequential (+fix a minor off-by-one bug)

## Which issue(s) this PR fixes

https://github.com/grafana/oncall-private/issues/1680

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2023-07-18 17:17:53 +00:00
..
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
action.py add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
alerts.py add several new database columns + emit two new Django signals (#1522) 2023-04-14 09:15:57 +02:00
escalation_chains.py Allow editing assigned team via public api (#1619) 2023-04-05 06:39:30 +00:00
escalation_policies.py Fix duplicate orders on routes and escalation policies (#2568) 2023-07-18 17:17:53 +00:00
incidents.py add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
integrations.py Remove INTEGRATIONS_TO_REVERSE_URL_MAP (#2533) 2023-07-17 04:43:24 +00:00
integtration_heartbeat.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
maintenance.py add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
on_call_shifts.py Unify "name" and "title" field for oncall shift (#2239) 2023-06-14 19:05:19 +00:00
organizations.py remove organization maintenance mode + fix integration maintenance mode (#2511) 2023-07-12 16:41:44 -04:00
personal_notification_rules.py Fix duplicate orders on routes and escalation policies (#2568) 2023-07-18 17:17:53 +00:00
resolution_notes.py remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
routes.py Fix duplicate orders on routes and escalation policies (#2568) 2023-07-18 17:17:53 +00:00
schedules_base.py add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
schedules_calendar.py Allow editing assigned team via public api (#1619) 2023-04-05 06:39:30 +00:00
schedules_ical.py Allow editing assigned team via public api (#1619) 2023-04-05 06:39:30 +00:00
schedules_polymorphic.py Initial web schedule model and serializers. Add override shift type. 2022-07-05 12:41:55 -03:00
schedules_web.py Allow editing assigned team via public api (#1619) 2023-04-05 06:39:30 +00:00
slack_channel.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
teams.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
user_groups.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
users.py Add RBAC Support (#777) 2022-11-29 09:41:56 +01:00