oncall-engine/grafana-plugin
Joey Orlando 6e5cb4e8a7
[UI] fix eslint/prettier warnings (#678)
* UI spring cleaning

- fix ~570 outstanding eslint warnings
- make eslint force user to correct warnings
- remove .css files that are not referenced
- remove dummy.tsx as it is not consumed anywhere
- remove a few functions that were "dead code" (ie. not consumed anywhere)
- remove commented out blocks of code that had no explanatory comments surrounding them

* add prettier to pre-commit configuration

* change ignoreRestSiblings to true

we have a few spots in the codebase where we destructure
an object key and then use something like ...restProps
setting this to true allows that

* upgrade from eslint 7.21.0 to 8.25.0
- add @grafana/eslint-config to dev dependencies and pre-commit eslint deps
- add @grafana/eslint-config peer dependencies to package.json

* fix remaining outstanding prettier warnings

* enable noUnusedLocals and noUnusedParameters and fix errors related to this

* make pre-commit complain about eslint warnings

* import from moment-timezone instead of moment

* fix react/display-name eslint warning

* add eslint-plugin-react-hooks to dev deps

this is a peer dependency from @grafana/eslint-config

* turn off react/prop-types

* temporarily turn off react-hooks/exhaustive-deps

add note that it will be turned back on and fixed in next PR

* fix unused import errors after rebase to dev

* fix more new prettier errors

* turn react/no-unescaped-entities eslint rule off

* address PR comment about useReducer

* remove includeTemplateGroup from src/components/AlertTemplates/AlertTemplatesForm.helper.tsx

* update arg typing for refreshPageError

* update handleSyncException typing

* fix strict equality in containers/IntegrationSettings/parts/Autoresolve.tsx

* enhance typing in components/AlertTemplates/AlertTemplatesForm.tsx

* revert small change per Maxim's comment
2022-10-24 20:27:03 +08:00
..
e2e World, meet OnCall! 2022-06-03 08:09:47 -06:00
provisioning World, meet OnCall! 2022-06-03 08:09:47 -06:00
src [UI] fix eslint/prettier warnings (#678) 2022-10-24 20:27:03 +08:00
tools Merge dev to main (#54) 2022-06-13 16:39:58 -06:00
.eslintignore World, meet OnCall! 2022-06-03 08:09:47 -06:00
.eslintrc.js [UI] fix eslint/prettier warnings (#678) 2022-10-24 20:27:03 +08:00
.gitignore World, meet OnCall! 2022-06-03 08:09:47 -06:00
.nvmrc #539 - add slack permalink to alert group public API response (#543) 2022-09-22 15:17:17 +02:00
.prettierrc.js World, meet OnCall! 2022-06-03 08:09:47 -06:00
.release-it.js World, meet OnCall! 2022-06-03 08:09:47 -06:00
.stylelintignore World, meet OnCall! 2022-06-03 08:09:47 -06:00
.stylelintrc [UI] fix eslint/prettier warnings (#678) 2022-10-24 20:27:03 +08:00
CHANGELOG.md Update changelog for v1.0.39 2022-10-03 11:18:49 -06:00
grafana-plugin.yml.example World, meet OnCall! 2022-06-03 08:09:47 -06:00
jest.config.js more jest stuff 2022-10-11 16:06:05 +03:00
LICENSE World, meet OnCall! 2022-06-03 08:09:47 -06:00
package.json [UI] fix eslint/prettier warnings (#678) 2022-10-24 20:27:03 +08:00
plopfile.js Merge dev to main (#54) 2022-06-13 16:39:58 -06:00
tsconfig.json [UI] fix eslint/prettier warnings (#678) 2022-10-24 20:27:03 +08:00
webpack.config.js [UI] fix eslint/prettier warnings (#678) 2022-10-24 20:27:03 +08:00
yarn.lock [UI] fix eslint/prettier warnings (#678) 2022-10-24 20:27:03 +08:00