oncall-engine/engine/apps/api/tests/test_escalation_chain.py
Yulya Artyukhina 7e54a43f50
Fix team changing on PUT request if team is not in request data (#3530)
# What this PR does
Removes setting team to default value on PUT request to internal
endpoints if team is not in request data.
(For integrations, escalation chains, schedules and webhooks)

## Which issue(s) this PR fixes
https://github.com/grafana/oncall-private/issues/2368

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2023-12-07 14:44:52 +00:00

158 lines
5.6 KiB
Python

import json
import pytest
from django.urls import reverse
from rest_framework import status
from rest_framework.test import APIClient
from common.api_helpers.filters import NO_TEAM_VALUE
@pytest.fixture()
def escalation_chain_internal_api_setup(make_organization_and_user_with_plugin_token, make_escalation_chain):
organization, user, token = make_organization_and_user_with_plugin_token()
escalation_chain = make_escalation_chain(organization)
return user, token, escalation_chain
@pytest.mark.django_db
def test_delete_escalation_chain(escalation_chain_internal_api_setup, make_user_auth_headers):
user, token, escalation_chain = escalation_chain_internal_api_setup
client = APIClient()
url = reverse("api-internal:escalation_chain-detail", kwargs={"pk": escalation_chain.public_primary_key})
response = client.delete(url, **make_user_auth_headers(user, token))
assert response.status_code == status.HTTP_204_NO_CONTENT
@pytest.mark.django_db
def test_update_escalation_chain(escalation_chain_internal_api_setup, make_user_auth_headers):
user, token, escalation_chain = escalation_chain_internal_api_setup
client = APIClient()
url = reverse("api-internal:escalation_chain-detail", kwargs={"pk": escalation_chain.public_primary_key})
data = {
"name": "escalation_chain_updated",
"organization": escalation_chain.organization.public_primary_key,
"team": None,
}
response = client.put(
url, data=json.dumps(data), content_type="application/json", **make_user_auth_headers(user, token)
)
assert response.status_code == status.HTTP_200_OK
@pytest.mark.django_db
def test_list_escalation_chains(escalation_chain_internal_api_setup, make_user_auth_headers):
user, token, escalation_chain = escalation_chain_internal_api_setup
client = APIClient()
url = reverse("api-internal:escalation_chain-list")
response = client.get(url, **make_user_auth_headers(user, token))
assert response.status_code == status.HTTP_200_OK
assert response.json() == [
{
"id": escalation_chain.public_primary_key,
"name": escalation_chain.name,
"number_of_integrations": 0,
"number_of_routes": 0,
"team": None,
}
]
@pytest.mark.django_db
def test_list_escalation_chains_filters(escalation_chain_internal_api_setup, make_user_auth_headers):
user, token, escalation_chain = escalation_chain_internal_api_setup
client = APIClient()
url = reverse("api-internal:escalation_chain-list") + "?filters=true"
response = client.get(url, **make_user_auth_headers(user, token))
assert response.status_code == status.HTTP_200_OK
assert response.json() == [
{
"value": escalation_chain.public_primary_key,
"display_name": escalation_chain.name,
}
]
@pytest.mark.django_db
@pytest.mark.parametrize(
"team_name,new_team_name",
[
(None, None),
(None, "team_1"),
("team_1", None),
("team_1", "team_1"),
("team_1", "team_2"),
],
)
def test_escalation_chain_copy(
make_organization_and_user_with_plugin_token,
make_user_auth_headers,
make_escalation_chain,
make_team,
team_name,
new_team_name,
):
organization, user, token = make_organization_and_user_with_plugin_token()
team = make_team(organization, name=team_name) if team_name else None
new_team = make_team(organization, name=new_team_name) if new_team_name else None
escalation_chain = make_escalation_chain(organization, team=team)
data = {
"name": "escalation_chain_updated",
"team": new_team.public_primary_key if new_team else NO_TEAM_VALUE,
}
client = APIClient()
url = reverse("api-internal:escalation_chain-copy", kwargs={"pk": escalation_chain.public_primary_key})
response = client.post(url, data, format="json", **make_user_auth_headers(user, token))
assert response.status_code == status.HTTP_200_OK
assert response.json()["team"] == (new_team.public_primary_key if new_team else None)
@pytest.mark.django_db
def test_escalation_chain_copy_empty_name(
make_organization_and_user_with_plugin_token,
make_user_auth_headers,
make_escalation_chain,
):
organization, user, token = make_organization_and_user_with_plugin_token()
escalation_chain = make_escalation_chain(organization)
client = APIClient()
url = reverse("api-internal:escalation_chain-copy", kwargs={"pk": escalation_chain.public_primary_key})
response = client.post(
url, {"name": "", "team": NO_TEAM_VALUE}, format="json", **make_user_auth_headers(user, token)
)
assert response.status_code == status.HTTP_400_BAD_REQUEST
@pytest.mark.django_db
def test_team_not_updated_if_not_in_data(
make_organization_and_user_with_plugin_token,
make_team,
make_escalation_chain,
make_user_auth_headers,
):
organization, user, token = make_organization_and_user_with_plugin_token()
team = make_team(organization)
escalation_chain = make_escalation_chain(organization, team=team)
assert escalation_chain.team == team
client = APIClient()
url = reverse("api-internal:escalation_chain-detail", kwargs={"pk": escalation_chain.public_primary_key})
data = {"name": "escalation_chain_updated"}
response = client.put(url, data=data, format="json", **make_user_auth_headers(user, token))
assert response.status_code == status.HTTP_200_OK
assert response.json()["team"] == escalation_chain.team.public_primary_key
escalation_chain.refresh_from_db()
assert escalation_chain.team == team