centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
oncall-engine/engine/apps/slack
History
Joey Orlando 6a78ee6983
fix RBAC authz issue for Slack Alert Group actions (#3213) 
Was able to reproduce locally with OnCall RBAC enabled and as a user
with Viewer role:
<img width="701" alt="Screenshot 2023-10-30 at 09 30 52"
src="https://github.com/grafana/oncall/assets/9406895/0050c2b1-2765-4aba-a73e-985f364691ad">

Fixed with the changes introduced in this PR:
<img width="963" alt="Screenshot 2023-10-30 at 09 30 16"
src="https://github.com/grafana/oncall/assets/9406895/02b62f39-01e5-4a13-baaf-db30181eb16a">
<img width="967" alt="Screenshot 2023-10-30 at 09 30 11"
src="https://github.com/grafana/oncall/assets/9406895/c606f6db-8e99-4df4-a3e9-5c9da8feb051">



## Which issue(s) this PR fixes

Closes #3212 

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2023-10-30 09:48:54 -04:00
..
migrations Fix Slack access token length issue (#3016) 2023-09-13 11:53:17 +01:00
models Fix Slack access token length issue (#3016) 2023-09-13 11:53:17 +01:00
representatives Refactor AlertGroup.slack_message (#2957) 2023-09-04 18:03:18 +00:00
scenarios fix RBAC authz issue for Slack Alert Group actions (#3213) 2023-10-30 09:48:54 -04:00
tests Add responders improvements (#3128) 2023-10-27 12:12:07 -04:00
types Re-enable a few mypy rules + fix existing errors (#2725) 2023-08-03 09:43:03 +00:00
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
alert_group_slack_service.py Improve Slack error handling (#3000) 2023-09-12 09:49:16 +00:00
client.py Improve Slack error handling (#3000) 2023-09-12 09:49:16 +00:00
constants.py Shift Swap Requests in Slack + improve typing for Slack django app (#2653) 2023-07-28 15:11:38 +00:00
errors.py Improve Slack error handling (#3000) 2023-09-12 09:49:16 +00:00
slack_formatter.py Shift Swap Requests in Slack + improve typing for Slack django app (#2653) 2023-07-28 15:11:38 +00:00
tasks.py Improve Slack error handling (#3000) 2023-09-12 09:49:16 +00:00
test_slack_message.py Improve Slack error handling (#3000) 2023-09-12 09:49:16 +00:00
urls.py Shift Swap Requests in Slack + improve typing for Slack django app (#2653) 2023-07-28 15:11:38 +00:00
utils.py Improve Slack error handling (#3000) 2023-09-12 09:49:16 +00:00
views.py Improve Slack error handling (#3000) 2023-09-12 09:49:16 +00:00