a29e35c25a
# What this PR does Related to https://github.com/grafana/oncall-private/issues/2947 **NOTE** This PR introduces steps 1 and 2 of the 3 part migration proposed [here](https://raintank-corp.slack.com/archives/C06K1MQ07GS/p1732555465144099). Step 3, swapping reads to be from the new-column and dropping dual-writes, will be done in a future PR/release. --- I’m tackling this work now because _ultimately_ I want to move `AlertReceiveChannel.rate_limited_in_slack_at` to `SlackChannel.rate_limited_at` , but first I sorta need to refactor `SlackMessage.channel_id` from a `CHAR` field to a foreign key relationship (because in the spots where we touch Slack rate limiting, like [here](https://github.com/grafana/oncall/blob/dev/engine/apps/slack/alert_group_slack_service.py#L42-L50) for example, we only have `slack_message.channel_id`, which means I need to do extra queries to fetch the appropriate `SlackChannel` to then be able to get/set `SlackChannel.rate_limited_at` Other minor stuffs: - it also prepares us to drop `SlackMessage._slack_team_identity`. We already have a `@property` of `SlackMessage.slack_team_identity` (which [previously had some hacky logic](https://github.com/grafana/oncall/blob/dev/engine/apps/slack/models/slack_message.py#L74-L84)). I've refactored `SlackMessage.slack_team_identity` to simply point to `self.organization.slack_team_identity` + updated our code to _stop_ setting `SlackMessage._slack_team_identity` (will drop this column in future release) ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
115 lines
4.2 KiB
Python
115 lines
4.2 KiB
Python
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from apps.alerts.models import AlertGroup
|
|
from apps.slack.errors import get_error_class
|
|
from apps.slack.models import SlackMessage
|
|
from apps.slack.scenarios.distribute_alerts import AlertShootingStep
|
|
from apps.slack.scenarios.scenario_step import ScenarioStep
|
|
from apps.slack.tests.conftest import build_slack_response
|
|
|
|
|
|
@pytest.mark.django_db
|
|
@pytest.mark.parametrize(
|
|
"reason,slack_error",
|
|
[
|
|
(reason, slack_error)
|
|
for reason, slack_error in AlertGroup.REASONS_TO_SKIP_ESCALATIONS
|
|
if reason != AlertGroup.NO_REASON
|
|
],
|
|
)
|
|
def test_skip_escalations_error(
|
|
make_organization_and_user_with_slack_identities,
|
|
make_alert_receive_channel,
|
|
make_alert_group,
|
|
make_alert,
|
|
make_slack_channel,
|
|
reason,
|
|
slack_error,
|
|
):
|
|
SlackAlertShootingStep = ScenarioStep.get_step("distribute_alerts", "AlertShootingStep")
|
|
organization, _, slack_team_identity, _ = make_organization_and_user_with_slack_identities()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
alert = make_alert(alert_group, raw_request_data="{}")
|
|
|
|
slack_channel = make_slack_channel(slack_team_identity)
|
|
|
|
step = SlackAlertShootingStep(slack_team_identity)
|
|
|
|
with patch.object(step._slack_client, "api_call") as mock_slack_api_call:
|
|
error_response = build_slack_response({"error": slack_error})
|
|
error_class = get_error_class(error_response)
|
|
mock_slack_api_call.side_effect = error_class(error_response)
|
|
|
|
channel = slack_channel
|
|
if reason == AlertGroup.CHANNEL_NOT_SPECIFIED:
|
|
channel = None
|
|
|
|
step._post_alert_group_to_slack(slack_team_identity, alert_group, alert, None, channel, [])
|
|
|
|
alert_group.refresh_from_db()
|
|
alert.refresh_from_db()
|
|
assert alert_group.reason_to_skip_escalation == reason
|
|
assert alert_group.slack_message is None
|
|
assert SlackMessage.objects.count() == 0
|
|
assert not alert.delivered
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_timeout_error(
|
|
make_slack_team_identity,
|
|
make_slack_channel,
|
|
make_organization,
|
|
make_alert_receive_channel,
|
|
make_alert_group,
|
|
make_alert,
|
|
):
|
|
SlackAlertShootingStep = ScenarioStep.get_step("distribute_alerts", "AlertShootingStep")
|
|
slack_team_identity = make_slack_team_identity()
|
|
slack_channel = make_slack_channel(slack_team_identity)
|
|
organization = make_organization(slack_team_identity=slack_team_identity, default_slack_channel=slack_channel)
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
alert = make_alert(alert_group, raw_request_data="{}")
|
|
|
|
step = SlackAlertShootingStep(slack_team_identity)
|
|
|
|
with pytest.raises(TimeoutError):
|
|
with patch.object(step._slack_client, "api_call") as mock_slack_api_call:
|
|
mock_slack_api_call.side_effect = TimeoutError
|
|
step.process_signal(alert)
|
|
|
|
alert_group.refresh_from_db()
|
|
alert.refresh_from_db()
|
|
assert alert_group.slack_message is None
|
|
assert alert_group.slack_message_sent is False
|
|
assert SlackMessage.objects.count() == 0
|
|
assert not alert.delivered
|
|
|
|
|
|
@patch.object(AlertShootingStep, "_post_alert_group_to_slack")
|
|
@pytest.mark.django_db
|
|
def test_alert_shooting_no_channel_filter(
|
|
mock_post_alert_group_to_slack,
|
|
make_slack_team_identity,
|
|
make_slack_channel,
|
|
make_organization,
|
|
make_alert_receive_channel,
|
|
make_alert_group,
|
|
make_alert,
|
|
):
|
|
slack_team_identity = make_slack_team_identity()
|
|
slack_channel = make_slack_channel(slack_team_identity, slack_id="DEFAULT_CHANNEL_ID")
|
|
organization = make_organization(slack_team_identity=slack_team_identity, default_slack_channel=slack_channel)
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
|
|
# simulate an alert group with channel filter deleted in the middle of the escalation
|
|
alert_group = make_alert_group(alert_receive_channel, channel_filter=None)
|
|
alert = make_alert(alert_group, raw_request_data={})
|
|
|
|
step = AlertShootingStep(slack_team_identity, organization)
|
|
step.process_signal(alert)
|
|
|
|
assert mock_post_alert_group_to_slack.call_args[1]["slack_channel"] == slack_channel
|