a29e35c25a
# What this PR does Related to https://github.com/grafana/oncall-private/issues/2947 **NOTE** This PR introduces steps 1 and 2 of the 3 part migration proposed [here](https://raintank-corp.slack.com/archives/C06K1MQ07GS/p1732555465144099). Step 3, swapping reads to be from the new-column and dropping dual-writes, will be done in a future PR/release. --- I’m tackling this work now because _ultimately_ I want to move `AlertReceiveChannel.rate_limited_in_slack_at` to `SlackChannel.rate_limited_at` , but first I sorta need to refactor `SlackMessage.channel_id` from a `CHAR` field to a foreign key relationship (because in the spots where we touch Slack rate limiting, like [here](https://github.com/grafana/oncall/blob/dev/engine/apps/slack/alert_group_slack_service.py#L42-L50) for example, we only have `slack_message.channel_id`, which means I need to do extra queries to fetch the appropriate `SlackChannel` to then be able to get/set `SlackChannel.rate_limited_at` Other minor stuffs: - it also prepares us to drop `SlackMessage._slack_team_identity`. We already have a `@property` of `SlackMessage.slack_team_identity` (which [previously had some hacky logic](https://github.com/grafana/oncall/blob/dev/engine/apps/slack/models/slack_message.py#L74-L84)). I've refactored `SlackMessage.slack_team_identity` to simply point to `self.organization.slack_team_identity` + updated our code to _stop_ setting `SlackMessage._slack_team_identity` (will drop this column in future release) ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
103 lines
3.6 KiB
Python
103 lines
3.6 KiB
Python
import logging
|
|
import typing
|
|
|
|
from apps.slack.client import SlackClient
|
|
from apps.slack.errors import (
|
|
SlackAPICantUpdateMessageError,
|
|
SlackAPIChannelArchivedError,
|
|
SlackAPIChannelInactiveError,
|
|
SlackAPIChannelNotFoundError,
|
|
SlackAPIInvalidAuthError,
|
|
SlackAPIMessageNotFoundError,
|
|
SlackAPIRatelimitError,
|
|
SlackAPITokenError,
|
|
)
|
|
|
|
if typing.TYPE_CHECKING:
|
|
from apps.alerts.models import AlertGroup
|
|
from apps.slack.models import SlackTeamIdentity
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class AlertGroupSlackService:
|
|
_slack_client: SlackClient
|
|
|
|
def __init__(
|
|
self,
|
|
slack_team_identity: "SlackTeamIdentity",
|
|
slack_client: typing.Optional[SlackClient] = None,
|
|
):
|
|
self.slack_team_identity = slack_team_identity
|
|
if slack_client is not None:
|
|
self._slack_client = slack_client
|
|
else:
|
|
self._slack_client = SlackClient(slack_team_identity)
|
|
|
|
def update_alert_group_slack_message(self, alert_group: "AlertGroup") -> None:
|
|
logger.info(f"Update message for alert_group {alert_group.pk}")
|
|
|
|
try:
|
|
self._slack_client.chat_update(
|
|
channel=alert_group.slack_message.channel.slack_id,
|
|
ts=alert_group.slack_message.slack_id,
|
|
attachments=alert_group.render_slack_attachments(),
|
|
blocks=alert_group.render_slack_blocks(),
|
|
)
|
|
logger.info(f"Message has been updated for alert_group {alert_group.pk}")
|
|
except SlackAPIRatelimitError as e:
|
|
if not alert_group.channel.is_maintenace_integration:
|
|
if not alert_group.channel.is_rate_limited_in_slack:
|
|
alert_group.channel.start_send_rate_limit_message_task(e.retry_after)
|
|
logger.info(
|
|
f"Message has not been updated for alert_group {alert_group.pk} due to slack rate limit."
|
|
)
|
|
else:
|
|
raise
|
|
except (
|
|
SlackAPIMessageNotFoundError,
|
|
SlackAPICantUpdateMessageError,
|
|
SlackAPIChannelInactiveError,
|
|
SlackAPITokenError,
|
|
SlackAPIChannelNotFoundError,
|
|
):
|
|
pass
|
|
|
|
def publish_message_to_alert_group_thread(
|
|
self, alert_group: "AlertGroup", attachments=None, mrkdwn=True, unfurl_links=True, text=None
|
|
) -> None:
|
|
# TODO: refactor checking the possibility of sending message to slack
|
|
# do not try to post message to slack if integration is rate limited
|
|
if alert_group.channel.is_rate_limited_in_slack:
|
|
return
|
|
|
|
slack_message = alert_group.slack_message
|
|
|
|
if attachments is None:
|
|
attachments = []
|
|
|
|
try:
|
|
result = self._slack_client.chat_postMessage(
|
|
channel=slack_message.channel.slack_id,
|
|
text=text,
|
|
attachments=attachments,
|
|
thread_ts=slack_message.slack_id,
|
|
mrkdwn=mrkdwn,
|
|
unfurl_links=unfurl_links,
|
|
)
|
|
except (
|
|
SlackAPITokenError,
|
|
SlackAPIChannelArchivedError,
|
|
SlackAPIChannelNotFoundError,
|
|
SlackAPIInvalidAuthError,
|
|
):
|
|
return
|
|
|
|
# TODO: once _channel_id has been fully migrated to channel, remove _channel_id
|
|
# see https://raintank-corp.slack.com/archives/C06K1MQ07GS/p1732555465144099
|
|
alert_group.slack_messages.create(
|
|
slack_id=result["ts"],
|
|
organization=alert_group.channel.organization,
|
|
_channel_id=slack_message.channel.slack_id,
|
|
channel=slack_message.channel,
|
|
)
|