centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
oncall-engine/engine/apps
History
Vadim Stepanov 602ed535e3
Fix duplicate orders on routes and escalation policies (#2568) 
# What this PR does

Fix duplicate `order` values for models `EscalationPolicy` and
`ChannelFilter` using the same approach as
https://github.com/grafana/oncall/pull/2278.

- Make internal API action `move_to_position` a part of
[OrderedModelViewSet](https://github.com/grafana/oncall/pull/2568/files#diff-eb62521ccbcb072d1bd2156adeadae3b5895bce6d0d54432a23db3948b0ada54R11-R34),
so all ordered model views use the same logic.
- Make public API serializers for ordered models inherit from
[OrderedModelSerializer](https://github.com/grafana/oncall/pull/2568/files#diff-d749f94af5a49adaf5074325cdfad10ddd5a52dbfd78b49582867ebb9c92fae5R6-R38),
so ordered model views are consistent with each other in public API.
- Remove `order` from plugin fronted, since it's not being used
anywhere. The frontend uses step indices & `move_to_position` action
instead.
- Make escalation snapshot use step indices instead of orders, since
orders are not guaranteed to be sequential (+fix a minor off-by-one bug)

## Which issue(s) this PR fixes

https://github.com/grafana/oncall-private/issues/1680

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2023-07-18 17:17:53 +00:00
..
alerts Fix duplicate orders on routes and escalation policies (#2568) 2023-07-18 17:17:53 +00:00
api Fix duplicate orders on routes and escalation policies (#2568) 2023-07-18 17:17:53 +00:00
api_for_grafana_incident remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
auth_token add missing database migrations 2023-07-05 18:27:56 +02:00
base Fix duplicate orders on routes and escalation policies (#2568) 2023-07-18 17:17:53 +00:00
email remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
grafana_plugin fix parsing of grafana feature flags that're enabled via the feature_toggles.enabled syntax (#2477) 2023-07-10 04:59:15 -04:00
heartbeat remove deprecated heartbeat_heartbeat table/model (#2534) 2023-07-17 01:38:04 -04:00
integrations remove deprecated heartbeat_heartbeat table/model (#2534) 2023-07-17 01:38:04 -04:00
metrics_exporter Add "user_was_notified_of_alert_groups" metric (#2334) 2023-06-28 08:15:19 +00:00
mobile_app remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
oss_installation augment API response pagination attributes (#2471) 2023-07-14 11:19:40 -04:00
phone_notifications set default phone provider (#2523) 2023-07-17 13:04:55 +00:00
public_api Fix duplicate orders on routes and escalation policies (#2568) 2023-07-18 17:17:53 +00:00
schedules Exclude schedules from deleted organizations from notification list (#2493) 2023-07-11 10:32:10 +00:00
slack remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
social_auth Reworked slack login pipeline errors (#2526) 2023-07-18 13:31:11 +00:00
telegram remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
twilioapp remove deprecated backend code (#2502) 2023-07-12 02:07:45 -04:00
user_management mark manual_severity and resolution_note_ts columns on alertgroup table as deprecated (#2564) 2023-07-18 09:41:58 +00:00
webhooks remove references to AlertGroup.is_archived and AlertGroup.unarchived_objects (#2524) 2023-07-18 11:48:34 +00:00
zvonok Update CHANGELOG.md 2023-07-05 14:30:51 +08:00
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00