# What this PR does **Cleanup label typing:** 1. LabelParam -> two separate types LabekKey and LabelValue 2. LabelData -> renamed to LabelPair. 3. LabelKeyData -> renamed to LabelOption Data is not giving any info about what this type represents. 4. Remove LabelsData and LabelsKeysData types. They are just list of types listed above and with new naming it feels obsolete. 5. ValueData removed. LabelPair is used instead. 6. Rework AlertGroupCustomLabel to use LabelKey type for key to make type system more consistent. Name model type AlertGroupCustomLabel**DB** and api type AlertGroupCustomLabel**API** to clearly distinguish them. **Split update_labels_cache into two tasks** update_label_option_cache and update_label_pairs_cache. Original task was expecting array of LabelsData (now it's LabelPair) OR one LabelKeyData ( now it's LabelOption). I believe having one function with two sp different argument types makes it more complicated for understanding. **Make OnCall backend support prescribed labels**. OnCall will sync and store "prescribed" field for key and values, so Label dropdown able to disable editing for certain labels. ## Which issue(s) this PR fixes ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Maxim Mordasov <maxim.mordasov@grafana.com> Co-authored-by: Yulya Artyukhina <Ferril.darkdiver@gmail.com>
175 lines
7.1 KiB
Python
175 lines
7.1 KiB
Python
import typing
|
|
|
|
from django.db import models
|
|
from django.utils import timezone
|
|
|
|
from apps.labels.tasks import update_label_pairs_cache
|
|
from apps.labels.types import LabelPair
|
|
from apps.labels.utils import LABEL_OUTDATED_TIMEOUT_MINUTES
|
|
|
|
if typing.TYPE_CHECKING:
|
|
from apps.user_management.models import Organization
|
|
|
|
|
|
MAX_KEY_NAME_LENGTH = 200
|
|
MAX_VALUE_NAME_LENGTH = 200
|
|
|
|
|
|
class LabelKeyCache(models.Model):
|
|
id = models.CharField(primary_key=True, editable=False, max_length=36)
|
|
name = models.CharField(max_length=MAX_KEY_NAME_LENGTH)
|
|
organization = models.ForeignKey("user_management.Organization", on_delete=models.CASCADE)
|
|
last_synced = models.DateTimeField(auto_now=True)
|
|
prescribed = models.BooleanField(default=False, null=True)
|
|
|
|
@property
|
|
def is_outdated(self) -> bool:
|
|
return timezone.now() - self.last_synced > timezone.timedelta(minutes=LABEL_OUTDATED_TIMEOUT_MINUTES)
|
|
|
|
|
|
class LabelValueCache(models.Model):
|
|
id = models.CharField(primary_key=True, editable=False, max_length=36)
|
|
name = models.CharField(max_length=MAX_VALUE_NAME_LENGTH)
|
|
key = models.ForeignKey("labels.LabelKeyCache", on_delete=models.CASCADE, related_name="values")
|
|
last_synced = models.DateTimeField(auto_now=True)
|
|
prescribed = models.BooleanField(default=False, null=True)
|
|
|
|
@property
|
|
def is_outdated(self) -> bool:
|
|
return timezone.now() - self.last_synced > timezone.timedelta(minutes=LABEL_OUTDATED_TIMEOUT_MINUTES)
|
|
|
|
|
|
class AssociatedLabel(models.Model):
|
|
"""
|
|
Abstract model, is used to keep information about label association with other instances
|
|
(integrations, schedules, etc.). To add ability to associate labels with a type of instances ,
|
|
inhere this model and add a foreign key to the instance model.
|
|
|
|
Attention: add `AssociatedLabel` to the end of the name of inheritor (example: AlertReceiveChannelAssociatedLabel)
|
|
"""
|
|
|
|
key = models.ForeignKey(LabelKeyCache, on_delete=models.CASCADE)
|
|
value = models.ForeignKey(LabelValueCache, on_delete=models.CASCADE)
|
|
organization = models.ForeignKey("user_management.Organization", on_delete=models.CASCADE, related_name="labels")
|
|
|
|
class Meta:
|
|
abstract = True
|
|
|
|
@staticmethod
|
|
def update_association(
|
|
label_pairs: typing.List[LabelPair], instance: models.Model, organization: "Organization"
|
|
) -> None:
|
|
"""
|
|
Update label associations for selected instance: delete associations with labels that are not in `labels_data`,
|
|
create new associations and labels, if needed.
|
|
Then call celery task to update cache for labels from `labels_data`
|
|
|
|
instance: the model instance that the labels are associated with (e.g. AlertReceiveChannel instance)
|
|
"""
|
|
labels_data_keys = {label["key"]["id"]: label["key"]["name"] for label in label_pairs}
|
|
labels_data_values = {label["value"]["id"]: label["value"]["name"] for label in label_pairs}
|
|
|
|
# delete associations with labels that are not presented in labels_data
|
|
instance.labels.exclude(key_id__in=labels_data_keys.keys(), value_id__in=labels_data_values.keys()).delete()
|
|
|
|
labels_keys = []
|
|
labels_values = []
|
|
labels_associations = []
|
|
|
|
for label_pair in label_pairs:
|
|
key_id = label_pair["key"]["id"]
|
|
key_name = label_pair["key"]["name"]
|
|
key_prescribed = label_pair["key"]["prescribed"]
|
|
|
|
value_id = label_pair["value"]["id"]
|
|
value_name = label_pair["value"]["name"]
|
|
value_prescribed = label_pair["value"]["prescribed"]
|
|
|
|
label_key = LabelKeyCache(id=key_id, name=key_name, organization=organization, prescribed=key_prescribed)
|
|
labels_keys.append(label_key)
|
|
|
|
label_value = LabelValueCache(id=value_id, name=value_name, key_id=key_id, prescribed=value_prescribed)
|
|
labels_values.append(label_value)
|
|
associated_instance = {instance.labels.field.name: instance}
|
|
labels_associations.append(
|
|
instance.labels.model(
|
|
key_id=key_id, value_id=value_id, organization=organization, **associated_instance
|
|
)
|
|
)
|
|
|
|
# create labels cache and associations that don't exist.
|
|
# Ignoring conflicts because some labels might laready exist. They will be updates in task.
|
|
LabelKeyCache.objects.bulk_create(labels_keys, ignore_conflicts=True, batch_size=5000)
|
|
LabelValueCache.objects.bulk_create(labels_values, ignore_conflicts=True, batch_size=5000)
|
|
instance.labels.model.objects.bulk_create(labels_associations, ignore_conflicts=True, batch_size=5000)
|
|
|
|
update_label_pairs_cache.apply_async((label_pairs,))
|
|
|
|
@staticmethod
|
|
def get_associating_label_field_name() -> str:
|
|
"""Returns ForeignKey field name for the associated model"""
|
|
raise NotImplementedError
|
|
|
|
|
|
class AlertReceiveChannelAssociatedLabel(AssociatedLabel):
|
|
"""Keeps information about label association with alert receive channel instances"""
|
|
|
|
alert_receive_channel = models.ForeignKey(
|
|
"alerts.AlertReceiveChannel", on_delete=models.CASCADE, related_name="labels"
|
|
)
|
|
|
|
# If inheritable is True, then the label will be passed down to alert groups
|
|
inheritable = models.BooleanField(default=True, null=True)
|
|
|
|
class Meta:
|
|
unique_together = ["key_id", "value_id", "alert_receive_channel_id"]
|
|
|
|
@staticmethod
|
|
def get_associating_label_field_name() -> str:
|
|
"""Returns ForeignKey field name for the associated model"""
|
|
return "alert_receive_channel"
|
|
|
|
|
|
class AlertGroupAssociatedLabel(models.Model):
|
|
"""
|
|
A model for alert group labels (similar to AlertReceiveChannelAssociatedLabel for integrations).
|
|
The key difference is that alert group labels do not use label IDs, but rather key and value names explicitly.
|
|
This is done to make alert group labels "static" (so they don't change when the labels are updated in label repo).
|
|
"""
|
|
|
|
alert_group = models.ForeignKey("alerts.AlertGroup", on_delete=models.CASCADE, related_name="labels")
|
|
organization = models.ForeignKey(
|
|
"user_management.Organization", on_delete=models.CASCADE, related_name="alert_group_labels"
|
|
)
|
|
|
|
key_name = models.CharField(max_length=MAX_KEY_NAME_LENGTH)
|
|
value_name = models.CharField(max_length=MAX_VALUE_NAME_LENGTH)
|
|
|
|
class Meta:
|
|
constraints = [
|
|
models.UniqueConstraint(
|
|
fields=["organization", "key_name", "value_name", "alert_group"],
|
|
name="unique_alert_group_label",
|
|
)
|
|
]
|
|
|
|
|
|
class WebhookAssociatedLabel(AssociatedLabel):
|
|
"""Keeps information about label association with outgoing webhooks instances"""
|
|
|
|
webhook = models.ForeignKey(
|
|
"webhooks.Webhook",
|
|
on_delete=models.CASCADE,
|
|
related_name="labels",
|
|
)
|
|
organization = models.ForeignKey(
|
|
"user_management.Organization", on_delete=models.CASCADE, related_name="webhook_labels"
|
|
)
|
|
|
|
class Meta:
|
|
unique_together = ["key_id", "value_id", "webhook_id"]
|
|
|
|
@staticmethod
|
|
def get_associating_label_field_name() -> str:
|
|
"""Returns ForeignKey field name for the associated model"""
|
|
return "webhook"
|