# What this PR does New secret values were being generated for OnCall secrets `secretKey` and `mirageSecretKey` even when a fixed value was provided in the `values.yaml` file. This causes encryption of tokens to break in the DB through inconsistency when things are redeployed. This PR fixes it so that the value will only be generated if it is not set and the values in `values.yaml` are used. ## Which issue(s) this PR closes Closes [issue link here] <!-- *Note*: if you have more than one GitHub issue that this PR closes, be sure to preface each issue link with a [closing keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue). This ensures that the issue(s) are auto-closed once the PR has been merged. --> ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes. |
||
|---|---|---|
| .. | ||
| oncall | ||
| cr.yaml | ||
| ct.yaml | ||
| kind.yml | ||
| local_image.yml | ||
| README.md | ||
| simple.yml | ||
How to run the chart locally
-
Create the cluster with kind
Make sure ports 30001, 30002 (Grafana, optional) and 30003 (detached integrations server, optional) are free on your machine
kind create cluster --image kindest/node:v1.24.7 --config kind.yml -
(Optional) Build oncall image locally and load it to kind cluster
docker build ../engine -t oncall/engine:latest --target dev kind load docker-image oncall/engine:latestAlso make sure to add the following lines to your
simple.yml(you may also need to enabledevMode):image: repository: oncall/engine tag: latest pullPolicy: IfNotPresent oncall: devMode: trueAlternatively you can also pass an extra
--values ./local_image.ymlin the command below. -
Install the helm chart
helm install helm-testing \ --wait \ --values ./simple.yml \ ./oncall -
Get credentials
echo "\n\nOpen Grafana on localhost:30002 with credentials - user: admin, password: $(kubectl get secret --namespace default helm-testing-grafana -o jsonpath="{.data.admin-password}" | base64 --decode ; echo)" echo "Open Plugins -> Grafana OnCall -> fill form: backend url: http://host.docker.internal:30001" -
Clean up If you happen to
helm uninstall helm-testingbe sure to delete all the Persistent Volume Claims, as Postgres stores the auto-generated password on disk, and the nexthelm installwill fail.kubectl delete pvc --all kubectl delete pv --allThis, of course, will delete all the PVs and PVCs also :-)
kind delete cluster