56743857ee
# What this PR does Refactors the "invite" functionality in Slack to use direct paging and be more consistent with the web UI and `/escalate` Slack command. ## Screenshots ### Alert group buttons Before: <img width="609" alt="Screenshot 2023-07-17 at 22 40 47" src="https://github.com/grafana/oncall/assets/20116910/68fad5a4-5011-4d74-b1c7-362bdb4f8cf0"> After (replace "Invite..." dropdown with "Responders" button, swap it with the silence button): <img width="587" alt="Screenshot 2023-07-17 at 22 37 19" src="https://github.com/grafana/oncall/assets/20116910/50b42057-f46b-4558-ab1c-56c34a15af5e"> ### What happens when clicking on "Responders" The following modal opens up with a list of currently paged users and inputs to page more users/schedules: <img width="514" alt="Screenshot 2023-07-17 at 22 37 52" src="https://github.com/grafana/oncall/assets/20116910/70bd2853-d459-4343-8b25-8519ac0098f7"> This is supposed to be the Slack equivalent of this part of the web UI: <img width="601" alt="Screenshot 2023-07-17 at 22 47 17" src="https://github.com/grafana/oncall/assets/20116910/101e1229-a5c4-404f-8388-eceee3e4820f"> ## Which issue(s) this PR fixes https://github.com/grafana/oncall/issues/2336 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
209 lines
8.6 KiB
Python
209 lines
8.6 KiB
Python
import json
|
|
|
|
import pytest
|
|
|
|
from apps.alerts.incident_appearance.renderers.slack_renderer import AlertGroupSlackRenderer
|
|
from apps.alerts.models import AlertGroup
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_acknowledge_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[0]
|
|
assert button["text"]["text"] == "Acknowledge"
|
|
assert json.loads(button["value"]) == {"organization_id": organization.pk, "alert_group_pk": alert_group.pk}
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_unacknowledge_button(
|
|
make_organization, make_alert_receive_channel, make_alert_group, make_alert
|
|
):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel, acknowledged=True)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[0]
|
|
assert button["text"]["text"] == "Unacknowledge"
|
|
assert json.loads(button["value"]) == {"organization_id": organization.pk, "alert_group_pk": alert_group.pk}
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_resolve_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[1]
|
|
assert button["text"]["text"] == "Resolve"
|
|
assert json.loads(button["value"]) == {"organization_id": organization.pk, "alert_group_pk": alert_group.pk}
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_unresolve_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel, resolved=True)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[0]
|
|
assert button["text"]["text"] == "Unresolve"
|
|
assert json.loads(button["value"]) == {"organization_id": organization.pk, "alert_group_pk": alert_group.pk}
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_responders_button(
|
|
make_organization, make_user, make_alert_receive_channel, make_alert_group, make_alert
|
|
):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[3]
|
|
assert button["text"]["text"] == "Responders"
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_stop_invite_button(
|
|
make_organization, make_user, make_alert_receive_channel, make_alert_group, make_alert, make_invitation
|
|
):
|
|
organization = make_organization()
|
|
user = make_user(organization=organization)
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
invitation = make_invitation(alert_group, user, user)
|
|
|
|
action = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[1]["actions"][0]
|
|
|
|
assert action["text"] == f"Stop inviting {user.username}"
|
|
assert json.loads(action["value"]) == {
|
|
"organization_id": organization.pk,
|
|
"alert_group_pk": alert_group.pk,
|
|
"invitation_id": invitation.pk,
|
|
}
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_silence_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[2]
|
|
assert button["placeholder"]["text"] == "Silence"
|
|
|
|
values = [json.loads(option["value"]) for option in button["options"]]
|
|
assert values == [
|
|
{"organization_id": organization.pk, "alert_group_pk": alert_group.pk, "delay": delay}
|
|
for delay, _ in AlertGroup.SILENCE_DELAY_OPTIONS
|
|
]
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_unsilence_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel, silenced=True)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
button = elements[2]
|
|
|
|
assert button["text"]["text"] == "Unsilence"
|
|
assert json.loads(button["value"]) == {
|
|
"organization_id": organization.pk,
|
|
"alert_group_pk": alert_group.pk,
|
|
}
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_attach_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel, silenced=True)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
button = elements[4]
|
|
|
|
assert button["text"]["text"] == "Attach to ..."
|
|
assert json.loads(button["value"]) == {
|
|
"organization_id": organization.pk,
|
|
"alert_group_pk": alert_group.pk,
|
|
}
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_unattach_button(make_organization, make_alert_receive_channel, make_alert_group, make_alert):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
|
|
root_alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=root_alert_group, raw_request_data={})
|
|
|
|
alert_group = make_alert_group(alert_receive_channel, root_alert_group=root_alert_group)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
action = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["actions"][0]
|
|
|
|
assert action["text"] == "Unattach"
|
|
assert json.loads(action["value"]) == {
|
|
"organization_id": organization.pk,
|
|
"alert_group_pk": alert_group.pk,
|
|
}
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_format_alert_button(
|
|
make_organization, make_alert_receive_channel, make_alert_group, make_alert
|
|
):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[5]
|
|
assert button["text"]["text"] == ":mag: Format Alert"
|
|
assert json.loads(button["value"]) == {"organization_id": organization.pk, "alert_group_pk": alert_group.pk}
|
|
|
|
|
|
@pytest.mark.django_db
|
|
def test_slack_renderer_resolution_notes_button(
|
|
make_organization, make_alert_receive_channel, make_alert_group, make_alert
|
|
):
|
|
organization = make_organization()
|
|
alert_receive_channel = make_alert_receive_channel(organization)
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
elements = AlertGroupSlackRenderer(alert_group).render_alert_group_attachments()[0]["blocks"][0]["elements"]
|
|
|
|
button = elements[6]
|
|
assert button["text"]["text"] == "Add Resolution notes"
|
|
assert json.loads(button["value"]) == {
|
|
"organization_id": organization.pk,
|
|
"alert_group_pk": alert_group.pk,
|
|
"resolution_note_window_action": "edit",
|
|
}
|