6caacf4048
# What this PR does - gracefully retry `apps.alerts.tasks.delete_alert_group.delete_alert_group` when hitting Slack ratelimits - remove Slack messages from the DB as soon as they are deleted from Slack, so the tasks are not retrying perpetually ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
31 lines
1.1 KiB
Python
31 lines
1.1 KiB
Python
from celery.utils.log import get_task_logger
|
|
from django.conf import settings
|
|
|
|
from apps.slack.errors import SlackAPIRatelimitError
|
|
from common.custom_celery_tasks import shared_dedicated_queue_retry_task
|
|
|
|
logger = get_task_logger(__name__)
|
|
|
|
|
|
@shared_dedicated_queue_retry_task(
|
|
autoretry_for=(Exception,), retry_backoff=True, max_retries=1 if settings.DEBUG else None
|
|
)
|
|
def delete_alert_group(alert_group_pk, user_pk):
|
|
from apps.alerts.models import AlertGroup
|
|
from apps.user_management.models import User
|
|
|
|
alert_group = AlertGroup.objects.filter(pk=alert_group_pk).first()
|
|
if not alert_group:
|
|
logger.debug("Alert group not found, skipping delete_alert_group")
|
|
return
|
|
|
|
user = User.objects.filter(pk=user_pk).first()
|
|
if not user:
|
|
logger.debug("User not found, skipping delete_alert_group")
|
|
return
|
|
|
|
try:
|
|
alert_group.delete_by_user(user)
|
|
except SlackAPIRatelimitError as e:
|
|
# Handle Slack API ratelimit raised in apps.slack.scenarios.distribute_alerts.DeleteGroupStep.process_signal
|
|
delete_alert_group.apply_async((alert_group_pk, user_pk), countdown=e.retry_after)
|