faa7099297
# What this PR does The current implementation of the direct paging feature doesn't page additional responders if the alert group is acknowledged, silenced, or resolved, and doesn't show any warnings for such cases. This PR makes so that adding responders for silenced & acknowledged alert groups actually pages the selected user / schedule. For resolved alert groups, a warning message will be shown both in web UI and Slack. ## Which issue(s) this PR fixes Related to https://github.com/grafana/oncall/issues/2442 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
49 lines
2 KiB
Python
49 lines
2 KiB
Python
from rest_framework import status
|
|
from rest_framework.permissions import IsAuthenticated
|
|
from rest_framework.response import Response
|
|
from rest_framework.views import APIView
|
|
|
|
from apps.alerts.paging import DirectPagingAlertGroupResolvedError, direct_paging
|
|
from apps.api.permissions import RBACPermission
|
|
from apps.api.serializers.paging import DirectPagingSerializer
|
|
from apps.auth_token.auth import PluginAuthentication
|
|
from common.api_helpers.exceptions import BadRequest
|
|
|
|
|
|
class DirectPagingAPIView(APIView):
|
|
authentication_classes = (PluginAuthentication,)
|
|
permission_classes = (IsAuthenticated, RBACPermission)
|
|
|
|
rbac_permissions = {
|
|
"post": [RBACPermission.Permissions.ALERT_GROUPS_WRITE],
|
|
}
|
|
|
|
def post(self, request):
|
|
organization = request.auth.organization
|
|
from_user = request.user
|
|
|
|
serializer = DirectPagingSerializer(
|
|
data=request.data, context={"organization": organization, "request": request}
|
|
)
|
|
serializer.is_valid(raise_exception=True)
|
|
|
|
users = [(user["instance"], user["important"]) for user in serializer.validated_data["users"]]
|
|
schedules = [
|
|
(schedule["instance"], schedule["important"]) for schedule in serializer.validated_data["schedules"]
|
|
]
|
|
try:
|
|
alert_group = direct_paging(
|
|
organization=organization,
|
|
team=serializer.validated_data["team"],
|
|
from_user=from_user,
|
|
title=serializer.validated_data["title"],
|
|
message=serializer.validated_data["message"],
|
|
users=users,
|
|
schedules=schedules,
|
|
escalation_chain=serializer.validated_data["escalation_chain"],
|
|
alert_group=serializer.validated_data["alert_group"],
|
|
)
|
|
except DirectPagingAlertGroupResolvedError:
|
|
raise BadRequest(detail=DirectPagingAlertGroupResolvedError.DETAIL)
|
|
|
|
return Response(data={"alert_group_id": alert_group.public_primary_key}, status=status.HTTP_200_OK)
|