182f18de2c
# What this PR does
Grafana provides two methods for enabling feature flags:
- `feature_toggles.enabled`
- `feature_toggles.<name_of_feature_flag>`
For example, to enable `accessControlOnCall` you could either do:
```json
{
"feature_toggles": {
"enabled": "accessControlOnCall,someOtherCoolFeatureFlag"
}
}
```
or:
```json
{
"feature_toggles": {
"accessControlOnCall": true,
"someOtherCoolFeatureFlag": true
}
}
```
In method 1, if they're multiple feature flags present, they are _comma
separated, not space separated_. This PR fixes this parsing issue.
## Checklist
- [x] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required) (N/A)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
66 lines
2.8 KiB
Python
66 lines
2.8 KiB
Python
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from apps.grafana_plugin.helpers.client import GcomAPIClient
|
|
|
|
|
|
class TestIsRbacEnabledForStack:
|
|
TEST_FEATURE_TOGGLE = "helloWorld"
|
|
|
|
@pytest.mark.parametrize(
|
|
"gcom_api_response,expected",
|
|
[
|
|
(None, False),
|
|
({}, False),
|
|
({"config": {}}, False),
|
|
({"config": {"feature_toggles": {}}}, False),
|
|
({"config": {"feature_toggles": {"accessControlOnCall": "false"}}}, False),
|
|
({"config": {"feature_toggles": {"accessControlOnCall": "true"}}}, True),
|
|
],
|
|
)
|
|
@patch("apps.grafana_plugin.helpers.client.GcomAPIClient.api_get")
|
|
def test_it_returns_based_on_feature_toggle_value(
|
|
self, mocked_gcom_api_client_api_get, gcom_api_response, expected
|
|
):
|
|
stack_id = 5
|
|
mocked_gcom_api_client_api_get.return_value = (gcom_api_response, {"status_code": 200})
|
|
|
|
api_client = GcomAPIClient("someFakeApiToken")
|
|
assert api_client.is_rbac_enabled_for_stack(stack_id) == expected
|
|
assert mocked_gcom_api_client_api_get.called_once_with(f"instances/{stack_id}?config=true")
|
|
|
|
@pytest.mark.parametrize(
|
|
"instance_info,expected",
|
|
[
|
|
({}, False),
|
|
({"config": {}}, False),
|
|
({"config": {"feature_toggles": {}}}, False),
|
|
({"config": {"feature_toggles": {"enable": "foo,bar,baz"}}}, False),
|
|
({"config": {"feature_toggles": {TEST_FEATURE_TOGGLE: "false"}}}, False),
|
|
# must be comma separated
|
|
({"config": {"feature_toggles": {"enable": f"foo,bar,{TEST_FEATURE_TOGGLE}baz"}}}, False),
|
|
# these cases will probably never happen, but lets account for them anyways
|
|
(
|
|
{
|
|
"config": {
|
|
"feature_toggles": {
|
|
"enable": f"foo,bar,baz,{TEST_FEATURE_TOGGLE}",
|
|
TEST_FEATURE_TOGGLE: "false",
|
|
}
|
|
}
|
|
},
|
|
True,
|
|
),
|
|
({"config": {"feature_toggles": {"enable": f"foo bar baz", TEST_FEATURE_TOGGLE: "true"}}}, True),
|
|
({"config": {"feature_toggles": {TEST_FEATURE_TOGGLE: "true"}}}, True),
|
|
# features enabled via feature_toggles.enable should be comma separated, not space separated
|
|
({"config": {"feature_toggles": {"enable": f"foo,bar,{TEST_FEATURE_TOGGLE},baz"}}}, True),
|
|
({"config": {"feature_toggles": {"enable": f"foo bar {TEST_FEATURE_TOGGLE} baz"}}}, False),
|
|
],
|
|
)
|
|
def test_feature_toggle_is_enabled(self, instance_info, expected) -> None:
|
|
assert (
|
|
GcomAPIClient("someFakeApiToken")._feature_toggle_is_enabled(instance_info, self.TEST_FEATURE_TOGGLE)
|
|
== expected
|
|
)
|