b2f4ffb98a
# What this PR does Remove [`apps.get_model`](https://docs.djangoproject.com/en/3.2/ref/applications/#django.apps.apps.get_model) invocations and use inline `import` statements in places where models are imported within functions/methods to avoid circular imports. I believe `import` statements are more appropriate for most use cases as they allow for better static code analysis & formatting, and solve the issue of circular imports without being unnecessarily dynamic as `apps.get_model`. With `import` statements, it's possible to: - Jump to model definitions in most IDEs - Automatically sort inline imports with `isort` - Find import errors faster/easier (most IDEs highlight broken imports) - Have more consistency across regular & inline imports when importing models This PR also adds a flake8 rule to ban imports of `django.apps.apps`, so it's harder to use `apps.get_model` by mistake (it's possible to ignore this rule by using `# noqa: I251`). The rule is not enforced on directories with migration files, because `apps.get_model` is often used to get a historical state of a model, which is useful when writing migrations ([see this SO answer for more details](https://stackoverflow.com/a/37769213)). So `apps.get_model` is considered OK in migrations (even necessary in some cases). ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
53 lines
2.4 KiB
Python
53 lines
2.4 KiB
Python
from django.conf import settings
|
|
from django.db import transaction
|
|
|
|
from common.custom_celery_tasks import shared_dedicated_queue_retry_task
|
|
|
|
from .compare_escalations import compare_escalations
|
|
from .send_alert_group_signal import send_alert_group_signal
|
|
from .task_logger import task_logger
|
|
|
|
|
|
@shared_dedicated_queue_retry_task(
|
|
autoretry_for=(Exception,), retry_backoff=True, max_retries=1 if settings.DEBUG else None
|
|
)
|
|
def unsilence_task(alert_group_pk):
|
|
from apps.alerts.models import AlertGroup, AlertGroupLogRecord
|
|
|
|
task_logger.info(f"Start unsilence_task for alert_group {alert_group_pk}")
|
|
with transaction.atomic():
|
|
try:
|
|
alert_group = AlertGroup.objects.filter(pk=alert_group_pk).select_for_update()[0] # Lock alert_group:
|
|
except IndexError:
|
|
task_logger.info(f"unsilence_task. alert_group {alert_group_pk} doesn't exist")
|
|
return
|
|
if not compare_escalations(unsilence_task.request.id, alert_group.unsilence_task_uuid):
|
|
task_logger.info(
|
|
f"unsilence_task. alert_group {alert_group.pk}.ID mismatch.Active: {alert_group.unsilence_task_uuid}"
|
|
)
|
|
return
|
|
if alert_group.status == AlertGroup.SILENCED and alert_group.is_root_alert_group:
|
|
initial_state = alert_group.state
|
|
task_logger.info(f"unsilence alert_group {alert_group_pk} and start escalation if needed")
|
|
|
|
alert_group.un_silence()
|
|
# update metrics
|
|
alert_group._update_metrics(
|
|
organization_id=alert_group.channel.organization_id,
|
|
previous_state=initial_state,
|
|
state=alert_group.state,
|
|
)
|
|
alert_group.start_escalation_if_needed()
|
|
un_silence_log_record = AlertGroupLogRecord(
|
|
type=AlertGroupLogRecord.TYPE_UN_SILENCE,
|
|
alert_group=alert_group,
|
|
reason="auto unsilence",
|
|
)
|
|
un_silence_log_record.save()
|
|
transaction.on_commit(lambda: send_alert_group_signal.apply_async((un_silence_log_record.pk,)))
|
|
else:
|
|
task_logger.info(
|
|
f"Failed to unsilence alert_group {alert_group_pk}: alert_group status: {alert_group.status}, "
|
|
f"is root: {alert_group.is_root_alert_group}"
|
|
)
|
|
task_logger.info(f"Finish unsilence_task for alert_group {alert_group_pk}")
|