# What this PR does https://www.loom.com/share/c5e10b5ec51343d0954c6f41cfd6a5fb ## Summary of backend changes - Add `AlertReceiveChannel.get_orgs_direct_paging_integrations` method and `AlertReceiveChannel.is_contactable` property. These are needed to be able to (optionally) filter down teams, in the `GET /teams` internal API endpoint ([here](https://github.com/grafana/oncall/pull/3128/files#diff-a4bd76e557f7e11dafb28a52c1034c075028c693b3c12d702d53c07fc6f24c05R55-R63)), to just teams that have a "contactable" Direct Paging integration - `engine/apps/alerts/paging.py` - update these functions to support new UX. In short `direct_paging` no longer takes a list of `ScheduleNotifications` or an `EscalationChain` object - add `user_is_oncall` helper function - add `_construct_title` helper function. In short if no `title` is provided, which is the case for Direct Pages originating from OnCall (either UI or Slack), then the format is `f"{from_user.username} is paging <team.name (if team is specified> <comma separated list of user.usernames> to join escalation"` - `engine/apps/api/serializers/team.py` - add `number_of_users_currently_oncall` attribute to response schema ([code](https://github.com/grafana/oncall/pull/3128/files#diff-26af48f796c9e987a76447586dd0f92349783d6ea6a0b6039a2f0f28bd58c2ebR45-R52)) - `engine/apps/api/serializers/user.py` - add `is_currently_oncall` attribute to response schema ([code](https://github.com/grafana/oncall/pull/3128/files#diff-6744b5544ebb120437af98a996da5ad7d48ee1139a6112c7e3904010ab98f232R157-R162)) - `engine/apps/api/views/team.py` - add support for two new optional query params `only_include_notifiable_teams` and `include_no_team` ([code](https://github.com/grafana/oncall/pull/3128/files#diff-a4bd76e557f7e11dafb28a52c1034c075028c693b3c12d702d53c07fc6f24c05R55-R70)) - `engine/apps/api/views/user.py` - in the `GET /users` internal API endpoint, when specifying the `search` query param now also search on `teams__name` ([code](https://github.com/grafana/oncall/pull/3128/files#diff-30309629484ad28e6fe09816e1bd226226d652ea977b6f3b6775976c729bf4b5R223); this is a new UX requirement) - add support for a new optional query param, `is_currently_oncall`, to allow filtering users based on.. whether they are currently on call or not ([code](https://github.com/grafana/oncall/pull/3128/files#diff-30309629484ad28e6fe09816e1bd226226d652ea977b6f3b6775976c729bf4b5R272-R282)) - remove `check_availability` endpoint (no longer used with new UX; also removed references in frontend code) - `engine/apps/slack/scenarios/paging.py` and `engine/apps/slack/scenarios/manage_responders.py` - update Slack workflows to support new UX. Schedules are no longer a concept here. When creating a new alert group via `/escalate` the user either specifies a team and/or user(s) (they must specify at least one of the two and validation is done here to check this). When adding responders to an existing alert group it's simply a list of users that they can add, no more schedules. - add `Organization.slack_is_configured` and `Organization.telegram_is_configured` properties. These are needed to support [this new functionality ](https://github.com/grafana/oncall/pull/3128/files#diff-9d96504027309f2bd1e95352bac1433b09b60eb4fafb611b52a6c15ed16cbc48R271-R272) in the `AlertReceiveChannel` model. ## Summary of frontend changes - Refactor/rename `EscalationVariants` component to `AddResponders` + remove `grafana-plugin/src/containers/UserWarningModal` (no longer needed with new UX) - Remove `grafana-plugin/src/models/user.ts` as it seemed to be a duplicate of `grafana-plugin/src/models/user/user.types.ts` Related to https://github.com/grafana/incident/issues/4278 - Closes #3115 - Closes #3116 - Closes #3117 - Closes #3118 - Closes #3177 ## TODO - [x] make frontend changes - [x] update Slack backend functionality - [x] update public documentation - [x] add/update e2e tests ## Post-deploy To-dos - [ ] update dev/ops/production Slack bots to update `/escalate` command description (should now say "Direct page a team or user(s)") ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
106 lines
4.1 KiB
Python
106 lines
4.1 KiB
Python
from rest_framework import serializers
|
|
|
|
from apps.api.serializers.user_group import UserGroupSerializer
|
|
from apps.schedules.models import OnCallSchedule
|
|
from apps.schedules.tasks import schedule_notify_about_empty_shifts_in_schedule, schedule_notify_about_gaps_in_schedule
|
|
from common.api_helpers.custom_fields import TeamPrimaryKeyRelatedField
|
|
from common.api_helpers.mixins import EagerLoadingMixin
|
|
from common.api_helpers.utils import CurrentOrganizationDefault, CurrentTeamDefault
|
|
|
|
|
|
class ScheduleBaseSerializer(EagerLoadingMixin, serializers.ModelSerializer):
|
|
id = serializers.CharField(read_only=True, source="public_primary_key")
|
|
organization = serializers.HiddenField(default=CurrentOrganizationDefault())
|
|
team = TeamPrimaryKeyRelatedField(allow_null=True, default=CurrentTeamDefault())
|
|
slack_channel = serializers.SerializerMethodField()
|
|
user_group = UserGroupSerializer()
|
|
warnings = serializers.SerializerMethodField()
|
|
on_call_now = serializers.SerializerMethodField()
|
|
number_of_escalation_chains = serializers.SerializerMethodField()
|
|
enable_web_overrides = serializers.SerializerMethodField()
|
|
|
|
class Meta:
|
|
fields = [
|
|
"id",
|
|
"organization",
|
|
"team",
|
|
"name",
|
|
"user_group",
|
|
"warnings",
|
|
"on_call_now",
|
|
"has_gaps",
|
|
"notify_oncall_shift_freq",
|
|
"notify_empty_oncall",
|
|
"mention_oncall_start",
|
|
"mention_oncall_next",
|
|
"number_of_escalation_chains",
|
|
"enable_web_overrides",
|
|
]
|
|
|
|
SELECT_RELATED = ["organization"]
|
|
|
|
CANT_UPDATE_USER_GROUP_WARNING = (
|
|
"Cannot update the user group, make sure to grant user group modification rights to "
|
|
"non-admin users in Slack workspace settings"
|
|
)
|
|
SCHEDULE_HAS_GAPS_WARNING = "Schedule has unassigned time periods during next 7 days"
|
|
SCHEDULE_HAS_EMPTY_SHIFTS_WARNING = "Schedule has empty shifts during next 7 days"
|
|
|
|
def get_slack_channel(self, obj):
|
|
if obj.channel is None:
|
|
return None
|
|
return {
|
|
"display_name": obj.slack_channel_name,
|
|
"slack_id": obj.channel,
|
|
"id": obj.slack_channel_pk,
|
|
}
|
|
|
|
def get_warnings(self, obj):
|
|
can_update_user_groups = self.context.get("can_update_user_groups", False)
|
|
warnings = []
|
|
if obj.user_group and not can_update_user_groups:
|
|
warnings.append(self.CANT_UPDATE_USER_GROUP_WARNING)
|
|
if obj.has_gaps:
|
|
warnings.append(self.SCHEDULE_HAS_GAPS_WARNING)
|
|
if obj.has_empty_shifts:
|
|
warnings.append(self.SCHEDULE_HAS_EMPTY_SHIFTS_WARNING)
|
|
return warnings
|
|
|
|
def get_on_call_now(self, obj):
|
|
# Serializer context is set here: apps.api.views.schedule.ScheduleView.get_serializer_context
|
|
users = self.context["oncall_users"].get(obj, [])
|
|
return [user.short() for user in users]
|
|
|
|
def get_number_of_escalation_chains(self, obj):
|
|
# num_escalation_chains param added in queryset via annotate. Check ScheduleView.get_queryset
|
|
# return 0 for just created schedules
|
|
num = getattr(obj, "num_escalation_chains", 0)
|
|
return num or 0
|
|
|
|
def get_enable_web_overrides(self, obj):
|
|
return False
|
|
|
|
def validate(self, attrs):
|
|
if "slack_channel_id" in attrs:
|
|
slack_channel_id = attrs.pop("slack_channel_id", None)
|
|
attrs["channel"] = slack_channel_id.slack_id if slack_channel_id is not None else None
|
|
return attrs
|
|
|
|
def create(self, validated_data):
|
|
created_schedule = super().create(validated_data)
|
|
created_schedule.check_empty_shifts_for_next_week()
|
|
schedule_notify_about_empty_shifts_in_schedule.apply_async((created_schedule.pk,))
|
|
created_schedule.check_gaps_for_next_week()
|
|
schedule_notify_about_gaps_in_schedule.apply_async((created_schedule.pk,))
|
|
return created_schedule
|
|
|
|
|
|
class ScheduleFastSerializer(serializers.ModelSerializer):
|
|
id = serializers.CharField(read_only=True, source="public_primary_key")
|
|
|
|
class Meta:
|
|
model = OnCallSchedule
|
|
fields = [
|
|
"id",
|
|
"name",
|
|
]
|