centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
oncall-engine/engine/apps/slack
History
Joey Orlando 01b1be85af
fix mypy return errors (#2408) 
# What this PR does

Fix the following `return` `mypy` errors (related to #2392):

```bash
❯ mypy .
apps/telegram/updates/update_manager.py:36: error: Missing return statement  [return]
apps/slack/scenarios/step_mixins.py:109: error: Missing return statement  [return]
apps/mobile_app/tasks.py:368: error: Missing return statement  [return]
apps/telegram/updates/update_handlers/button_press.py:48: error: Missing return statement  [return]
apps/twilioapp/phone_provider.py:28: error: Missing return statement  [return]
apps/twilioapp/phone_provider.py:61: error: Missing return statement  [return]
Found 6 errors in 5 files (checked 595 source files)
```

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
2023-07-05 11:36:59 +00:00
..
migrations remove SlackActionRecord model/table (#2201) 2023-06-13 10:56:06 +00:00
models re-enable mypy GitHub Actions CI job (#2390) 2023-06-29 14:01:52 +00:00
representatives Refactor maintenance (#1340) 2023-02-23 07:13:03 +00:00
scenarios fix mypy return errors (#2408) 2023-07-05 11:36:59 +00:00
slack_client add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
templates/admin World, meet OnCall! 2022-06-03 08:09:47 -06:00
tests remove SlackActionRecord model/table (#2201) 2023-06-13 10:56:06 +00:00
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
admin.py remove SlackActionRecord model/table (#2201) 2023-06-13 10:56:06 +00:00
alert_group_slack_service.py Cleanup ScenarioStep (#1213) 2023-02-21 20:22:11 +01:00
constants.py continue addressing mypy violations (#2170) 2023-06-27 10:23:08 +00:00
slack_formatter.py continue addressing mypy violations (#2170) 2023-06-27 10:23:08 +00:00
tasks.py add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
urls.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
utils.py add mypy static type checker to backend codebase (#2151) 2023-06-12 12:50:33 -04:00
views.py Simplify SlackEventApiEndpointView methods (#2384) 2023-06-29 16:23:33 +00:00