oncall-engine/engine/apps
Joey Orlando 34a90134fb
patch default user notification policy changes + fix failing e2e test (#4635)
# What this PR does

This is a follow-up PR to https://github.com/grafana/oncall/pull/4628.
As @Ferril pointed out, there was a slight issue in
`apps.alerts.tasks.notify_user.perform_notification` method when using a
"fallback"/default user notification policy. This is because the
`log_record_pk` arg passed into `perform_notification` will fetch the
`UserNotificationPolicyLogRecord` object, but that object will have a
`notification_policy` set to `None` (because there's no persistent
`UserNotificationPolicy` object to refer to).

Instead we now pass in a second argument to `perform_notification`,
`use_default_notification_policy_fallback`. If this is true, simply grab
the transient/in-memory `UserNotificationPolicy` and use that inside of
this task

Related to https://github.com/grafana/oncall/issues/4410

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-07-09 11:23:53 -04:00
..
alerts patch default user notification policy changes + fix failing e2e test (#4635) 2024-07-09 11:23:53 -04:00
api Add filtering by team, is_currently_oncall and search on the user page (#4575) 2024-07-08 04:02:04 +00:00
api_for_grafana_incident add labels in grafana-incident alertgroup endpoint (#4448) 2024-06-25 14:50:55 +00:00
auth_token Google OAuth2 flow + fetch Google Calendar OOO events (#4067) 2024-04-02 14:59:03 -04:00
base patch default user notification policy changes + fix failing e2e test (#4635) 2024-07-09 11:23:53 -04:00
chatops_proxy Tweak chatops-proxy sync (#4627) 2024-07-08 15:33:58 +00:00
email patch default user notification policy changes + fix failing e2e test (#4635) 2024-07-09 11:23:53 -04:00
exotel add exotel call provider (#4433) 2024-06-06 06:19:02 +00:00
google Update out of office task to not retry on HttpError (#4328) 2024-05-09 16:16:46 +00:00
grafana_plugin Don't retry cleanup tasks (#4633) 2024-07-08 20:04:46 +00:00
heartbeat Improve OpenAPI schema coverage (#3629) 2024-01-12 15:11:22 +00:00
integrations Add tilt button to run pytest, fix local dev config for pytest, minor improvements to til (#3927) 2024-07-09 01:24:18 +00:00
labels Support prescribed labels (#3848) 2024-02-20 14:42:51 +08:00
metrics_exporter Add service_name label to insight metrics (#4300) 2024-05-22 14:17:42 +00:00
mobile_app rename settings/ci-test.py to settings/ci_test.py (#4391) 2024-05-24 13:55:08 +00:00
oss_installation bump uwsgi to 2.0.26 + Python to 3.12.3 (#4495) 2024-06-10 15:33:37 -04:00
phone_notifications Add spacing between words in notifications. (#4574) 2024-06-21 19:07:04 +00:00
public_api don't force create default user notification policies (#4608) 2024-07-05 15:08:17 -04:00
schedules bump uwsgi to 2.0.26 + Python to 3.12.3 (#4495) 2024-06-10 15:33:37 -04:00
slack Make Slack URLs work without trailing slashes (#4607) 2024-07-03 15:55:54 +00:00
social_auth Prepare OnCall for Unified Slack App (#4232) 2024-06-03 09:07:10 +00:00
telegram Prepare OnCall for Unified Slack App (#4232) 2024-06-03 09:07:10 +00:00
twilioapp Update alert group state by backsync (#4089) 2024-03-27 12:37:01 +00:00
user_management patch default user notification policy changes + fix failing e2e test (#4635) 2024-07-09 11:23:53 -04:00
webhooks Add tilt button to run pytest, fix local dev config for pytest, minor improvements to til (#3927) 2024-07-09 01:24:18 +00:00
zvonok change zvonok call verification (#4393) 2024-06-04 05:34:57 +00:00
__init__.py