oncall-engine/engine/engine
Joey Orlando a29e35c25a
refactor SlackMessage.channel_id (CHAR field) to SlackMessage.channel (foreign key relationship) (#5292)
# What this PR does

Related to https://github.com/grafana/oncall-private/issues/2947

**NOTE**

This PR introduces steps 1 and 2 of the 3 part migration proposed
[here](https://raintank-corp.slack.com/archives/C06K1MQ07GS/p1732555465144099).
Step 3, swapping reads to be from the new-column and dropping
dual-writes, will be done in a future PR/release.

---

I’m tackling this work now because _ultimately_ I want to move
`AlertReceiveChannel.rate_limited_in_slack_at` to
`SlackChannel.rate_limited_at` , but first I sorta need to refactor
`SlackMessage.channel_id` from a `CHAR` field to a foreign key
relationship (because in the spots where we touch Slack rate limiting,
like
[here](https://github.com/grafana/oncall/blob/dev/engine/apps/slack/alert_group_slack_service.py#L42-L50)
for example, we only have `slack_message.channel_id`, which means I need
to do extra queries to fetch the appropriate `SlackChannel` to then be
able to get/set `SlackChannel.rate_limited_at`

Other minor stuffs:
- it also prepares us to drop `SlackMessage._slack_team_identity`. We
already have a `@property` of `SlackMessage.slack_team_identity` (which
[previously had some hacky
logic](https://github.com/grafana/oncall/blob/dev/engine/apps/slack/models/slack_message.py#L74-L84)).
I've refactored `SlackMessage.slack_team_identity` to simply point to
`self.organization.slack_team_identity` + updated our code to _stop_
setting `SlackMessage._slack_team_identity` (will drop this column in
future release)

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-11-26 11:03:38 +00:00
..
management/commands refactor SlackMessage.channel_id (CHAR field) to SlackMessage.channel (foreign key relationship) (#5292) 2024-11-26 11:03:38 +00:00
tests Improve performance for deleted integration lookups (#4163) 2024-04-05 16:16:30 +00:00
__init__.py World, meet OnCall! 2022-06-03 08:09:47 -06:00
celery.py Remove kwargs from celery logging (#4316) 2024-05-07 14:29:49 +00:00
included_path.py Add openapi schema generation for internal api (#2771) 2023-08-16 06:13:56 +00:00
integrations_urls.py Add settings to allow detaching integrations server (#3203) 2023-10-26 12:55:02 +00:00
middlewares.py Inbound email better logging (#5271) 2024-11-21 12:39:11 +00:00
schema.py Improve OpenAPI schema coverage (#3629) 2024-01-12 15:11:22 +00:00
urls.py Rework organization sync and grafana plugin engine backend (#4756) 2024-07-31 16:12:56 +00:00
views.py Improve performance for deleted integration lookups (#4163) 2024-04-05 16:16:30 +00:00
wsgi.py Instrument requests lib (#4008) 2024-03-05 05:22:34 +00:00