d9c3d084be
# What this PR does Short summary: this PR improves security and configuration management for Helm deployment. Please take a look at the details below. ## Which issue(s) this PR fixes Issues: - Cannot explicitly define redis database (only 0 and 1 numbers are used) - Cannot securely use TLS for Redis (cannot set CA certificate; cannot set client certificates) - Cannot securely use TLS for Postgres (cannot set CA certificate; cannot set client certificates; cannot set `verify-full` validation) - ~~Chart option `securityContext.readOnlyRootFilesystem: true` issues CrashLoopBack pod state~~ will be moved to new PR ## Checklist - [x] ~~Unit, integration, and e2e (if applicable) tests updated~~ (not required) - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) - [x] Helm tests are fixed and updated - [x] Manually verified the features: - [x] postgres TLS connection with `verify-full` validation - [x] redis TLS connection with `cert_required` validation - [x] redis protocol and database number controls - [x] all containers properly work in read-only root filesystem - [x] all changes are backward compatible (doesn't break old deployments) ## Changelog - Fixed helm tests - Added configuration options for secure TLS communication with dependencies like Redis, MySQL, and Postgres - ~~Added configuration option for relocating `celerybeat` database file (read-only root filesystem issue)~~ will be moved to new PR - Improved redis database configuration options - Now only single redis database is used - Added ability to mount custom volumes (with CA certificates, for example) into Helm chart - ~~Fixed issue with read-only root filesystem for Helm chart~~ will be moved to new PR - Add ability to work with Redis ACL (and AWS ElastiCache)
94 lines
2.6 KiB
YAML
94 lines
2.6 KiB
YAML
suite: test Redis password envs for deployments
|
|
release:
|
|
name: oncall
|
|
templates:
|
|
- engine/deployment.yaml
|
|
- engine/job-migrate.yaml
|
|
- celery/deployment.yaml
|
|
- secrets.yaml
|
|
tests:
|
|
- it: secrets -> should fail if externalRedis.password not set
|
|
set:
|
|
broker.type: redis
|
|
redis.enabled: false
|
|
externalRedis.host: some-redis-host
|
|
asserts:
|
|
- failedTemplate:
|
|
errorMessage: externalRedis.password is required if not redis.enabled and not externalRedis.existingSecret
|
|
template: secrets.yaml
|
|
|
|
- it: externalRedis.password -> should create a Secret -redis-external
|
|
templates:
|
|
- engine/deployment.yaml
|
|
- engine/job-migrate.yaml
|
|
- celery/deployment.yaml
|
|
set:
|
|
broker.type: redis
|
|
redis.enabled: false
|
|
externalRedis:
|
|
host: some-redis-host
|
|
password: abcd123
|
|
asserts:
|
|
- contains:
|
|
path: spec.template.spec.containers[0].env
|
|
content:
|
|
name: REDIS_PASSWORD
|
|
valueFrom:
|
|
secretKeyRef:
|
|
name: oncall-redis-external
|
|
key: redis-password
|
|
- containsDocument:
|
|
kind: Secret
|
|
apiVersion: v1
|
|
metadata.name: oncall-redis-external
|
|
template: secrets.yaml
|
|
- equal:
|
|
path: data.redis-password
|
|
value: abcd123
|
|
decodeBase64: true
|
|
documentIndex: 1
|
|
template: secrets.yaml
|
|
|
|
- it: externalRedis.existingSecret -> should use existing secret
|
|
templates:
|
|
- engine/deployment.yaml
|
|
- engine/job-migrate.yaml
|
|
- celery/deployment.yaml
|
|
set:
|
|
broker.type: redis
|
|
redis.enabled: false
|
|
externalRedis:
|
|
host: some-redis-host
|
|
existingSecret: some-redis-secret
|
|
passwordKey: redis-password-key
|
|
asserts:
|
|
- contains:
|
|
path: spec.template.spec.containers[0].env
|
|
content:
|
|
name: REDIS_PASSWORD
|
|
valueFrom:
|
|
secretKeyRef:
|
|
name: some-redis-secret
|
|
key: redis-password-key
|
|
|
|
- it: externalRedis.passwordKey -> should be used for existing secret
|
|
templates:
|
|
- engine/deployment.yaml
|
|
- engine/job-migrate.yaml
|
|
- celery/deployment.yaml
|
|
set:
|
|
broker.type: redis
|
|
redis.enabled: false
|
|
externalRedis:
|
|
host: some-redis-host
|
|
existingSecret: some-redis-secret
|
|
passwordKey: redis.key
|
|
asserts:
|
|
- contains:
|
|
path: spec.template.spec.containers[0].env
|
|
content:
|
|
name: REDIS_PASSWORD
|
|
valueFrom:
|
|
secretKeyRef:
|
|
name: some-redis-secret
|
|
key: redis.key
|