d1085b718c
# What this PR does Prepare insight metrics for adding `service_name` label. This PR updates metrics cache structure, supporting both old and new version of cache. `service_name` label can be added with additional PR when all metric cache is updated. ## Which issue(s) this PR closes https://github.com/grafana/oncall-private/issues/2610 ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
215 lines
8.6 KiB
Python
215 lines
8.6 KiB
Python
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
from apps.base.models import UserNotificationPolicyLogRecord
|
|
from apps.metrics_exporter.constants import NO_SERVICE_VALUE, SERVICE_LABEL
|
|
from apps.metrics_exporter.helpers import (
|
|
get_metric_alert_groups_response_time_key,
|
|
get_metric_alert_groups_total_key,
|
|
get_metric_user_was_notified_of_alert_groups_key,
|
|
)
|
|
from apps.metrics_exporter.tasks import calculate_and_cache_metrics, calculate_and_cache_user_was_notified_metric
|
|
|
|
|
|
@patch("apps.alerts.models.alert_group.update_metrics_for_alert_group.apply_async")
|
|
@pytest.mark.django_db
|
|
def test_calculate_and_cache_metrics_task(
|
|
mocked_update_state_cache,
|
|
make_organization,
|
|
make_user_for_organization,
|
|
make_team,
|
|
make_alert_receive_channel,
|
|
make_alert_group,
|
|
make_alert,
|
|
make_alert_group_label_association,
|
|
):
|
|
METRICS_RESPONSE_TIME_LEN = 3 # 1 for each alert group with changed state (acked, resolved, silenced)
|
|
organization = make_organization()
|
|
team = make_team(organization)
|
|
|
|
alert_receive_channel_1 = make_alert_receive_channel(organization)
|
|
alert_receive_channel_2 = make_alert_receive_channel(organization, team=team)
|
|
for alert_receive_channel in [alert_receive_channel_1, alert_receive_channel_2]:
|
|
for _ in range(2):
|
|
alert_group = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group, raw_request_data={})
|
|
|
|
alert_group_to_ack = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group_to_ack, raw_request_data={})
|
|
alert_group_to_ack.acknowledge()
|
|
|
|
alert_group_to_res = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group_to_res, raw_request_data={})
|
|
alert_group_to_res.resolve()
|
|
|
|
alert_group_to_sil = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group_to_sil, raw_request_data={})
|
|
alert_group_to_sil.silence()
|
|
|
|
alert_group_to_ack_with_service = make_alert_group(alert_receive_channel)
|
|
make_alert(alert_group=alert_group_to_ack, raw_request_data={})
|
|
make_alert_group_label_association(
|
|
organization, alert_group_to_ack_with_service, key_name=SERVICE_LABEL, value_name="test"
|
|
)
|
|
alert_group_to_ack_with_service.acknowledge()
|
|
|
|
metric_alert_groups_total_key = get_metric_alert_groups_total_key(organization.id)
|
|
metric_alert_groups_response_time_key = get_metric_alert_groups_response_time_key(organization.id)
|
|
|
|
expected_result_metric_alert_groups_total = {
|
|
alert_receive_channel_1.id: {
|
|
"integration_name": alert_receive_channel_1.verbal_name,
|
|
"team_name": "No team",
|
|
"team_id": "no_team",
|
|
"org_id": organization.org_id,
|
|
"slug": organization.stack_slug,
|
|
"id": organization.stack_id,
|
|
"services": {
|
|
NO_SERVICE_VALUE: {
|
|
"firing": 2,
|
|
"silenced": 1,
|
|
"acknowledged": 1,
|
|
"resolved": 1,
|
|
},
|
|
"test": {
|
|
"firing": 0,
|
|
"silenced": 0,
|
|
"acknowledged": 1,
|
|
"resolved": 0,
|
|
},
|
|
},
|
|
},
|
|
alert_receive_channel_2.id: {
|
|
"integration_name": alert_receive_channel_2.verbal_name,
|
|
"team_name": team.name,
|
|
"team_id": team.id,
|
|
"org_id": organization.org_id,
|
|
"slug": organization.stack_slug,
|
|
"id": organization.stack_id,
|
|
"services": {
|
|
NO_SERVICE_VALUE: {
|
|
"firing": 2,
|
|
"silenced": 1,
|
|
"acknowledged": 1,
|
|
"resolved": 1,
|
|
},
|
|
"test": {
|
|
"firing": 0,
|
|
"silenced": 0,
|
|
"acknowledged": 1,
|
|
"resolved": 0,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
expected_result_metric_alert_groups_response_time = {
|
|
alert_receive_channel_1.id: {
|
|
"integration_name": alert_receive_channel_1.verbal_name,
|
|
"team_name": "No team",
|
|
"team_id": "no_team",
|
|
"org_id": organization.org_id,
|
|
"slug": organization.stack_slug,
|
|
"id": organization.stack_id,
|
|
"services": {NO_SERVICE_VALUE: [], "test": []},
|
|
},
|
|
alert_receive_channel_2.id: {
|
|
"integration_name": alert_receive_channel_2.verbal_name,
|
|
"team_name": team.name,
|
|
"team_id": team.id,
|
|
"org_id": organization.org_id,
|
|
"slug": organization.stack_slug,
|
|
"id": organization.stack_id,
|
|
"services": {NO_SERVICE_VALUE: [], "test": []},
|
|
},
|
|
}
|
|
|
|
with patch("apps.metrics_exporter.tasks.cache.set") as mock_cache_set:
|
|
calculate_and_cache_metrics(organization.id)
|
|
args = mock_cache_set.call_args_list
|
|
|
|
# check alert_groups_total metric cache
|
|
metric_alert_groups_total_values = args[0].args
|
|
assert metric_alert_groups_total_values[0] == metric_alert_groups_total_key
|
|
assert metric_alert_groups_total_values[1] == expected_result_metric_alert_groups_total
|
|
|
|
# check alert_groups_response_time metric cache
|
|
metric_alert_groups_response_time_values = args[1].args
|
|
assert metric_alert_groups_response_time_values[0] == metric_alert_groups_response_time_key
|
|
for integration_id, values in metric_alert_groups_response_time_values[1].items():
|
|
assert len(values["services"][NO_SERVICE_VALUE]) == METRICS_RESPONSE_TIME_LEN
|
|
# set response time to expected result because it is calculated on fly
|
|
expected_result_metric_alert_groups_response_time[integration_id]["services"][NO_SERVICE_VALUE] = values[
|
|
"services"
|
|
][NO_SERVICE_VALUE]
|
|
expected_result_metric_alert_groups_response_time[integration_id]["services"]["test"] = values["services"][
|
|
"test"
|
|
]
|
|
assert metric_alert_groups_response_time_values[1] == expected_result_metric_alert_groups_response_time
|
|
|
|
|
|
@patch("apps.alerts.models.alert_group.update_metrics_for_alert_group.apply_async")
|
|
@pytest.mark.django_db
|
|
def test_calculate_and_cache_user_was_notified_metric_task(
|
|
mocked_update_state_cache,
|
|
make_organization,
|
|
make_user_for_organization,
|
|
make_team,
|
|
make_alert_receive_channel,
|
|
make_alert_group,
|
|
make_alert,
|
|
make_user_notification_policy_log_record,
|
|
):
|
|
organization = make_organization()
|
|
team = make_team(organization)
|
|
|
|
user_1 = make_user_for_organization(organization)
|
|
user_2 = make_user_for_organization(organization)
|
|
|
|
alert_receive_channel_1 = make_alert_receive_channel(organization)
|
|
alert_receive_channel_2 = make_alert_receive_channel(organization, team=team)
|
|
|
|
alert_group_1 = make_alert_group(alert_receive_channel_1)
|
|
alert_group_2 = make_alert_group(alert_receive_channel_2)
|
|
|
|
for _ in range(2):
|
|
make_user_notification_policy_log_record(
|
|
type=UserNotificationPolicyLogRecord.TYPE_PERSONAL_NOTIFICATION_TRIGGERED,
|
|
author=user_1,
|
|
alert_group=alert_group_1,
|
|
)
|
|
|
|
for user in [user_1, user_2]:
|
|
make_user_notification_policy_log_record(
|
|
type=UserNotificationPolicyLogRecord.TYPE_PERSONAL_NOTIFICATION_TRIGGERED,
|
|
author=user,
|
|
alert_group=alert_group_2,
|
|
)
|
|
|
|
metric_user_was_notified_key = get_metric_user_was_notified_of_alert_groups_key(organization.id)
|
|
|
|
expected_result_metric_user_was_notified = {
|
|
user_1.id: {
|
|
"org_id": organization.org_id,
|
|
"slug": organization.stack_slug,
|
|
"id": organization.stack_id,
|
|
"user_username": user_1.username,
|
|
"counter": 2,
|
|
},
|
|
user_2.id: {
|
|
"org_id": organization.org_id,
|
|
"slug": organization.stack_slug,
|
|
"id": organization.stack_id,
|
|
"user_username": user_2.username,
|
|
"counter": 1,
|
|
},
|
|
}
|
|
|
|
with patch("apps.metrics_exporter.tasks.cache.set") as mock_cache_set:
|
|
calculate_and_cache_user_was_notified_metric(organization.id)
|
|
args = mock_cache_set.call_args_list
|
|
|
|
# check user_was_notified_of_alert_groups metric cache
|
|
metric_user_was_notified_of_alert_groups_values = args[0].args
|
|
assert metric_user_was_notified_of_alert_groups_values[0] == metric_user_was_notified_key
|
|
assert metric_user_was_notified_of_alert_groups_values[1] == expected_result_metric_user_was_notified
|