Commit graph

193 commits

Author SHA1 Message Date
Jack Baldry
de476846af
Remove "Add to docs project" workflow (#5135)
There's now a centralized workflow running in Writers' Toolkit that adds
issues from all repositories which removes the need to proliferate
per-repository workflows.

---------

Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
Co-authored-by: GitHub Actions <actions@github.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Co-authored-by: Matias Bordese <mbordese@gmail.com>
Co-authored-by: Vadim Stepanov <vadimkerr@gmail.com>
Co-authored-by: Dominik Broj <dominik.broj@grafana.com>
Co-authored-by: Michael Derynck <michael.derynck@grafana.com>
Co-authored-by: Yulya Artyukhina <Ferril.darkdiver@gmail.com>
Co-authored-by: Innokentii Konstantinov <innokenty.konstantinov@grafana.com>
Co-authored-by: Ildar Iskhakov <Ildar.iskhakov@grafana.com>
Co-authored-by: grafana-irm-app[bot] <165293418+grafana-irm-app[bot]@users.noreply.github.com>
2024-10-08 13:07:00 +00:00
Joey Orlando
0ef6bb7eda
main -> dev (#5084)
Co-authored-by: GitHub Actions <actions@github.com>
Co-authored-by: Matias Bordese <mbordese@gmail.com>
Co-authored-by: Vadim Stepanov <vadimkerr@gmail.com>
Co-authored-by: Dominik Broj <dominik.broj@grafana.com>
Co-authored-by: Michael Derynck <michael.derynck@grafana.com>
Co-authored-by: Yulya Artyukhina <Ferril.darkdiver@gmail.com>
Co-authored-by: Innokentii Konstantinov <innokenty.konstantinov@grafana.com>
Co-authored-by: Ildar Iskhakov <Ildar.iskhakov@grafana.com>
Co-authored-by: grafana-irm-app[bot] <165293418+grafana-irm-app[bot]@users.noreply.github.com>
2024-09-24 16:51:37 -04:00
Joey Orlando
9d20f61389
chore: merge helm request PRs using the grafana-irm-app GitHub App (#5078)
# What this PR does

Stop merging Helm release chart PRs as me 🙃 and instead use the "Grafana
IRM App" GitHub App credentials:

<img width="936" alt="Screenshot 2024-09-24 at 2 56 25 PM"
src="https://github.com/user-attachments/assets/477fdad0-4c0b-4ae9-b390-92187fcaf64c">
2024-09-24 15:31:59 -04:00
Joey Orlando
7586b04f8a
fix "on helm release pr merged" GitHub Actions workflow (#5069)
# What this PR does

- Closes https://github.com/grafana/oncall/issues/5065
- Fixes [failing update Helm repo github
workflows](https://github.com/grafana/oncall/actions/workflows/on-helm-release-pr-merged.yml)
(due to `secrets. GH_HELM_RELEASE` now seeming to return "Bad
credentials")

## TODO

- [ ] after this PR is merged and change merged to `main`, remove
`GH_HELM_RELEASE` repository secret

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-09-24 17:00:37 +00:00
Joey Orlando
737eaf79cc
ci: patch issue in gcom curl command (#5061)
## Which issue(s) this PR closes

Fix
https://github.com/grafana/oncall/actions/runs/10997991428/job/30535419238#step:9:1
2024-09-23 12:30:31 -04:00
Joey Orlando
e882e9782d
ci: update oss plugin release process (#5051)
# What this PR does

Related to https://github.com/grafana/irm/pull/137 (**NOTE**: should
only be merged after those changed are back-merged here into
`grafana/oncall`)

## Which issue(s) this PR closes

Also, fixes https://github.com/grafana/oncall/issues/5028

---------

Co-authored-by: Dominik <dominik.broj@grafana.com>
2024-09-23 11:56:16 -04:00
Joey Orlando
2cb8f4a24f
ci: fix snyk security scans (#5046)
# What this PR does

Similar to https://github.com/grafana/gops-labels/pull/137, use common
vault secret rather than the org github secret
2024-09-19 16:05:16 -04:00
Jack Baldry
d9b1196e3c
Use centralized 'Add to docs project' workflow with GitHub App auth (#5045)
Until this is merged, it is likely that any issues labeled `type/docs`
won't be added to the [organization
project](https://github.com/orgs/grafana/projects/69).

The underlying action is centralized so that any future changes are made
in one place (`grafana/writers-toolkit`). The action is versioned to
protect workflows from breaking changes.

The action uses Vault secrets instead of the discouraged organization
secrets.

The workflow uses a consistent name so that future changes can be made
programmatically.

Relates to
https://github.com/orgs/grafana/projects/279/views/9?pane=issue&itemId=44280262

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
2024-09-19 15:01:18 +00:00
Dominik Broj
392fa4c52c
fix: support running install-frontend-dependency from subdirectory (#4980)
# What this PR does

- support running install-frontend-dependency from subdirectory (used by
oncall-private)

## Which issue(s) this PR closes
https://raintank-corp.slack.com/archives/C06K1MQ07GS/p1725445756941869


<!--
*Note*: If you want the issue to be auto-closed once the PR is merged,
change "Related to" to "Closes" in the line above.
If you have more than one GitHub issue that this PR closes, be sure to
preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-09-04 14:27:39 +00:00
Vadim Stepanov
9340e3b9b8
Use cloud access policy to publish plugin to grafana.com (#4972)
related to https://github.com/grafana/oncall-private/issues/2881

use the same token to both sign and publish plugin
2024-09-03 14:20:15 +00:00
Dominik Broj
9bbd2c4db0
chore: Switch to pnpm + adjust to IRM (#4969)
# What this PR does
- switch to pnpm
- adjust to IRM

## Which issue(s) this PR closes

Related to:
https://github.com/grafana/irm/issues/12
https://github.com/grafana/irm/issues/11
https://github.com/grafana/irm/issues/66

<!--
*Note*: If you want the issue to be auto-closed once the PR is merged,
change "Related to" to "Closes" in the line above.
If you have more than one GitHub issue that this PR closes, be sure to
preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-09-02 12:48:23 +00:00
Rares Mardare
bbc46e0383
e2e to run against 11 (#4942) 2024-08-29 12:01:16 +00:00
Dominik Broj
0b6fa6ad1d
types improvements (#4945)
# What this PR does

- Fix some types errors when OnCall type checking runs under IRM
- Make type check required on CI


## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-08-28 14:43:52 +00:00
Rares Mardare
0965c6ab75
Fixed deprecated imports of H/VGroup in favor of Stack (#4897)
# What this PR does

Closes https://github.com/grafana/irm/issues/10
2024-08-27 09:37:30 +00:00
Joey Orlando
1ac0ae6ce2
update CODEOWNERS to account for a few extra golang files under grafana-plugin (#4917) 2024-08-26 10:34:12 -04:00
Joey Orlando
65dd0a7d20
upgrade Docker base image from python:3.12.3-alpine3.18 to python:3.12.3-alpine3.20 (#4879)
# What this PR does

Fixes [many
CVEs](https://ops.grafana-ops.net/a/grafana-vulnerabilityobs-app/sources/9/version/5561?var-package=&var-cve=CVE-2023-42363&var-riskLevel=$__all)
currently present in our `latest` tagged Docker image:

**Before**
<img width="1250" alt="Screenshot 2024-08-20 at 16 33 14"
src="https://github.com/user-attachments/assets/8215cefe-0a4c-44a8-a817-47d5d9633ceb">

**After**
<img width="1245" alt="Screenshot 2024-08-20 at 16 30 09"
src="https://github.com/user-attachments/assets/2ddc9246-edbc-4801-8dc4-cdc962786ef8">

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-08-20 20:44:18 +00:00
Joey Orlando
081c6bd2c2
fix synk security scan on CI (#4875)
# Which issue(s) this PR closes

Closes https://github.com/grafana/oncall/issues/4503
Closes https://github.com/grafana/oncall-private/issues/2876

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-08-20 15:06:54 -04:00
Dominik Broj
2164e75854
ci: fix expensive e2e tests (#4867)
wait until plugin backend is built before grafana starts via ops-devenv


## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-08-20 13:49:53 +00:00
Dominik Broj
c37100db38
chore: more adjustments to IRM monorepo (#4835)
# What this PR does

more adjustments to IRM monorepo

## Which issue(s) this PR closes

Related to https://github.com/grafana/irm/issues/11

<!--
*Note*: If you want the issue to be auto-closed once the PR is merged,
change "Related to" to "Closes" in the line above.
If you have more than one GitHub issue that this PR closes, be sure to
preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-08-20 10:07:33 +00:00
Dominik Broj
344cd0efde
Add missing labels permissions, fix tilt ci from ops-devenv, fix expensive e2e tests (#4842)
# What this PR does

- add missing labels-related permissions for external service account
used by new oncall init process
- fix expensive e2e tests in new oncall init process
- unify Grafana versions between standard and expensive e2e tests
- fix running tilt through ops-devenv in new oncall init process
- avoid duplicated standard e2e tests on workflows that run daily and on
merges to main

## Which issue(s) this PR closes

Related to https://github.com/grafana/oncall-private/issues/2656

<!--
*Note*: If you want the issue to be auto-closed once the PR is merged,
change "Related to" to "Closes" in the line above.
If you have more than one GitHub issue that this PR closes, be sure to
preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.

---------

Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
2024-08-19 18:17:10 +00:00
Dominik Broj
06d19bf6e9
New OnCall plugin initialization process (#4657)
# What this PR does

New OnCall plugin initialization process

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.

---------

Co-authored-by: Michael Derynck <michael.derynck@grafana.com>
Co-authored-by: Matias Bordese <mbordese@gmail.com>
2024-08-16 16:43:52 +00:00
Matias Bordese
a1c67cdfe7
Address deprecation warnings in tests (#4681)
Related to https://github.com/grafana/oncall/issues/4496

[No
warnings](https://github.com/grafana/oncall/actions/runs/10359091611/job/28674729718?pr=4681#step:5:305)!
2024-08-13 20:51:18 +00:00
Joey Orlando
535baf7fc8
Fix missing setuptools dep (#4799)
# What this PR does

_tldr;_ I think we should install `setuptools` into our engine
`Dockerfile` + in our CI env because Python 3.12 no longer installs
`distutils` by default. This should unblock us from being able to merge
#4656 and #4555.

**More details**

I would like to be able to merge #4656 and #4555. _However_, in both of
these PRs `setuptools` is being removed from `requirements-dev.txt`
([here](https://github.com/grafana/oncall/pull/4555/files#diff-d8146d0816a943b0fa69a20399d7bbdb58e1c84c8b7933b2ba6dea7c10c410f5L113-L116)
and
[here](https://github.com/grafana/oncall/pull/4656/files#diff-d8146d0816a943b0fa69a20399d7bbdb58e1c84c8b7933b2ba6dea7c10c410f5L113-L116)).
This leads to things breaking because of:
```bash
File "/opt/hostedtoolcache/Python/3.12.3/x64/lib/python3.12/site-packages/polymorphic/__init__.py", line 9, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
```

-
https://github.com/grafana/oncall/actions/runs/9865348392/job/27242117474?pr=4555#step:5:98
-
https://github.com/grafana/oncall/actions/runs/10078898966/job/27864920455?pr=4656#step:5:100

Python 3.12 made a change to no longer pre-install `distutils`
([relevant release
notes](https://docs.python.org/3/whatsnew/3.12.html#:~:text=The%20third%2Dparty%20Setuptools%20package%20continues%20to%20provide%20distutils%2C%20if%20you%20still%20require%20it%20in%20Python%203.12%20and%20beyond)):
> [PEP 632](https://peps.python.org/pep-0632/): Remove the distutils
package. See [the migration
guide](https://peps.python.org/pep-0632/#migration-advice) for advice
replacing the APIs it provided. The third-party
[Setuptools](https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html)
package continues to provide distutils, if you still require it in
Python 3.12 and beyond.
>
> [gh-95299](https://github.com/python/cpython/issues/95299): Do not
pre-install setuptools in virtual environments created with
[venv](https://docs.python.org/3/library/venv.html#module-venv). This
means that distutils, setuptools, pkg_resources, and easy_install will
no longer available by default; to access these run pip install
setuptools in the
[activated](https://docs.python.org/3/library/venv.html#venv-explanation)
virtual environment.

Additionally, `setuptools` is in `pip-tools` `UNSAFE_PACKAGES` list
([related GitHub
issue](https://github.com/pypa/pipenv/issues/1417#issuecomment-364795745)),
hence why I think Dependabot is removing it in #4656 and #4555.

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-08-09 20:09:47 +00:00
Vadim Stepanov
fbd68b10f3
Fix e2e test (#4787)
#4785 and #4786 continued
2024-08-07 13:19:35 +00:00
Dominik Broj
8d82b078d3
Cleanup and split tiltfile by profiles (#4691)
# What this PR does

Make it possible to select what resources are installed in Tilt by doing
`ONCALL_PROFILES=grafana,plugin,backend,tests tilt up`

## Which issue(s) this PR closes

Related to https://github.com/grafana/irm/issues/3

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-07-19 05:47:34 +00:00
Vadim Stepanov
65a794af0a
PR template: "Closes" -> "Related to" (#4693)
Make it so that you need to explicitly use the "Closes" keyword when
opening PRs (as per [this sprint retro
comment](https://miro.com/app/board/uXjVKzhhfgE=/?moveToWidget=3458764594901560846&cot=14))
2024-07-17 13:44:16 +00:00
Dominik Broj
93a7c645fd
bump nodejs version to latest stable (#4678)
# What this PR does

bump nodejs version to latest stable

## Which issue(s) this PR closes

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-07-16 11:16:23 +00:00
Dominik Broj
7da58c8eaa
run mage buildAll || true when building the plugin (#4658)
# What this PR does

`oncall-private` is using
[actions/build-sign-and-package-plugin/action.yml](https://github.com/grafana/oncall/pull/4658/files#diff-6200ac63c387869ca55bc34d1b343a96c667daef428602f910d696836cb09f84)
from the dev branch of this repo when doing the deployment. In order to
deploy new OnCall initialization which has Go backend component, we need
this action to install Go, Mage and do the `mage buildAll`. For other
branches where there are no Go files yet, it would just swallow the
error thanks to the `|| true` part

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-07-11 10:28:46 +00:00
Joey Orlando
6bb9fcef4c
update github issue product areas + label assignment 2024-06-14 12:52:14 -04:00
Joey Orlando
13f8c254fa
update product areas in issue templates 2024-06-14 12:26:41 -04:00
Joey Orlando
56683d2aa0
add release:ignore to update make docs procedure
PRs
2024-06-13 16:25:04 -04:00
Joey Orlando
9baba271b4
debugging helm release github actions workflow 2024-06-13 16:15:46 -04:00
Joey Orlando
40df01dc90
debugging helm release github actions workflow 2024-06-13 15:28:41 -04:00
Joey Orlando
76f3cd3158
debugging helm release github actions workflow 2024-06-13 15:24:20 -04:00
Joey Orlando
a1f5a69809
debugging helm release github actions workflow 2024-06-13 15:22:57 -04:00
Joey Orlando
d63c4f6c4a
debugging helm release github actions workflow 2024-06-13 15:17:54 -04:00
Joey Orlando
2d8627f1e2
debugging helm release github actions workflow 2024-06-13 15:10:15 -04:00
Joey Orlando
7cdef436a5
update token permissions for yaml update action 2024-06-13 14:46:17 -04:00
Joey Orlando
66f3ac5432
fix update make docs github actions workflow 2024-06-13 14:09:32 -04:00
Joey Orlando
5b995fdc57
fix linting 2024-06-13 14:01:32 -04:00
Joey Orlando
3133e3013d
simplify helm release github actions workflows into on release workflow 2024-06-13 13:50:37 -04:00
Joey Orlando
d032a4f909
minor github actions yml formatting 2024-06-13 13:43:21 -04:00
Joey Orlando
b411b92d1c
add on issue closed github actions workflow 2024-06-13 13:39:39 -04:00
Joey Orlando
b65b88d16a
update on release published github actions workflow 2024-06-11 13:50:03 -04:00
Joey Orlando
a4e399cf07
fix flaky tests + increase runner size when building docker image (#4502)
## Which issue(s) this PR closes

Closes https://github.com/grafana/oncall-private/issues/2733
2024-06-11 10:53:17 -04:00
Joey Orlando
518e22705a
fix Snyk action 2024-06-10 15:52:07 -04:00
Joey Orlando
8686ee30ac
update build-engine-docker-image-and-publish-to-dockerhub actions workflow 2024-06-10 15:49:33 -04:00
Joey Orlando
49d20f1a7e
bump uwsgi to 2.0.26 + Python to 3.12.3 (#4495)
# What this PR does

- bumps `uwsgi` to latest version (`2.0.26`), which unblocks us from
bumping Python to 3.12
- bumps Python to 3.12.3
- refactor the Snyk GitHub Actions workflow to use the composable
actions for installed frontend and backend dependencies
- fixes several `AttributeError`s in our tests that went from a warning
to an error in Python 3.12 (see
https://github.com/python/cpython/issues/100690)

# Which issue(s) this PR closes

Closes #4358
Closes https://github.com/grafana/oncall/issues/4387
2024-06-10 15:33:37 -04:00
Joey Orlando
4d3e254e3a
updating some github action versions (#4490) 2024-06-07 11:24:35 -04:00
Joey Orlando
f07e2207c5
update github action versions 2024-06-07 11:09:07 -04:00