Commit graph

25 commits

Author SHA1 Message Date
Matthew Thorning
a991fac43e
chore: update gh workflows with zizmor suggested fixes (#5523)
This pull request updates multiple GitHub Actions workflows to improve
security, stability, and functionality. The most notable changes include
pinning action versions to specific commit SHAs, adding validation for
branch names, and updating dependencies and configurations.

### Security Improvements:
* Added `persist-credentials: false` to `actions/checkout` steps in
`.github/workflows/build-engine-docker-image-and-publish-to-dockerhub.yml`
and `.github/workflows/e2e-tests.yml` to reduce the risk of unauthorized
access to credentials.
[[1]](diffhunk://#diff-f87667d48e22abfbbccf3695a8acc386143e3542286f432e6e3d8330960c76f9R29)
[[2]](diffhunk://#diff-194218c48b9a0cdd03974145733804c2d992ca818529fe2fa69a501d8b5b1cc3R48-R59)
* Validated branch names against a safe pattern in
`.github/workflows/linting-and-tests.yml` to prevent potential misuse of
branch names in subsequent steps.

### Stability Enhancements:
* Pinned all third-party GitHub Actions to specific commit SHAs across
various workflows to ensure consistent and predictable behavior.
Examples include
`grafana/shared-workflows/actions/build-push-to-dockerhub`,
`catchpoint/workflow-telemetry-action`, and
`actions-ecosystem/action-remove-labels`.
[[1]](diffhunk://#diff-f87667d48e22abfbbccf3695a8acc386143e3542286f432e6e3d8330960c76f9L37-R38)
[[2]](diffhunk://#diff-194218c48b9a0cdd03974145733804c2d992ca818529fe2fa69a501d8b5b1cc3R48-R59)
[[3]](diffhunk://#diff-f93a3de9563193d65121683e6383741ac4b6aa18bdb51ba82b80497e700561cdL15-R15)
* Updated Helm-related actions in
`.github/workflows/linting-and-tests.yml` and
`.github/workflows/on-release-published.yml` to specific SHAs for better
reliability.
[[1]](diffhunk://#diff-a70d3d29c45894eeef2036c533385dbc424f9479590aaea01e62c06dc67079a1L147-R170)
[[2]](diffhunk://#diff-e95a5d3f03a1351728732657b6b150cfbbd9a9724b387226b1f99f079b1954b0L91-R91)

### Functional Updates:
* Enhanced `.github/workflows/linting-and-tests.yml` by using validated
branch references in Git commands to avoid errors caused by unsafe
branch names.
* Updated `snyk/actions/setup` in
`.github/workflows/snyk-security-scan.yml` to a specific SHA for
improved compatibility and security.

These changes collectively enhance the security, reliability, and
maintainability of the workflows.
2025-05-01 08:56:34 -04:00
Joey Orlando
ab829458ff
remove snyk security scan as requirement from releases 2025-04-08 17:34:06 -04:00
Vadim Stepanov
615e1521ce
Use a different GH secret to sign plugin (#5447)
related to https://github.com/grafana/irm/issues/455, the secret was
populated as part of
https://github.com/grafana/deployment_tools/pull/221022
2025-02-12 17:48:37 +00:00
Joey Orlando
9d20f61389
chore: merge helm request PRs using the grafana-irm-app GitHub App (#5078)
# What this PR does

Stop merging Helm release chart PRs as me 🙃 and instead use the "Grafana
IRM App" GitHub App credentials:

<img width="936" alt="Screenshot 2024-09-24 at 2 56 25 PM"
src="https://github.com/user-attachments/assets/477fdad0-4c0b-4ae9-b390-92187fcaf64c">
2024-09-24 15:31:59 -04:00
Joey Orlando
737eaf79cc
ci: patch issue in gcom curl command (#5061)
## Which issue(s) this PR closes

Fix
https://github.com/grafana/oncall/actions/runs/10997991428/job/30535419238#step:9:1
2024-09-23 12:30:31 -04:00
Joey Orlando
e882e9782d
ci: update oss plugin release process (#5051)
# What this PR does

Related to https://github.com/grafana/irm/pull/137 (**NOTE**: should
only be merged after those changed are back-merged here into
`grafana/oncall`)

## Which issue(s) this PR closes

Also, fixes https://github.com/grafana/oncall/issues/5028

---------

Co-authored-by: Dominik <dominik.broj@grafana.com>
2024-09-23 11:56:16 -04:00
Vadim Stepanov
9340e3b9b8
Use cloud access policy to publish plugin to grafana.com (#4972)
related to https://github.com/grafana/oncall-private/issues/2881

use the same token to both sign and publish plugin
2024-09-03 14:20:15 +00:00
Joey Orlando
081c6bd2c2
fix synk security scan on CI (#4875)
# Which issue(s) this PR closes

Closes https://github.com/grafana/oncall/issues/4503
Closes https://github.com/grafana/oncall-private/issues/2876

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
2024-08-20 15:06:54 -04:00
Joey Orlando
9baba271b4
debugging helm release github actions workflow 2024-06-13 16:15:46 -04:00
Joey Orlando
40df01dc90
debugging helm release github actions workflow 2024-06-13 15:28:41 -04:00
Joey Orlando
76f3cd3158
debugging helm release github actions workflow 2024-06-13 15:24:20 -04:00
Joey Orlando
a1f5a69809
debugging helm release github actions workflow 2024-06-13 15:22:57 -04:00
Joey Orlando
d63c4f6c4a
debugging helm release github actions workflow 2024-06-13 15:17:54 -04:00
Joey Orlando
2d8627f1e2
debugging helm release github actions workflow 2024-06-13 15:10:15 -04:00
Joey Orlando
7cdef436a5
update token permissions for yaml update action 2024-06-13 14:46:17 -04:00
Joey Orlando
5b995fdc57
fix linting 2024-06-13 14:01:32 -04:00
Joey Orlando
3133e3013d
simplify helm release github actions workflows into on release workflow 2024-06-13 13:50:37 -04:00
Joey Orlando
b65b88d16a
update on release published github actions workflow 2024-06-11 13:50:03 -04:00
Joey Orlando
49d20f1a7e
bump uwsgi to 2.0.26 + Python to 3.12.3 (#4495)
# What this PR does

- bumps `uwsgi` to latest version (`2.0.26`), which unblocks us from
bumping Python to 3.12
- bumps Python to 3.12.3
- refactor the Snyk GitHub Actions workflow to use the composable
actions for installed frontend and backend dependencies
- fixes several `AttributeError`s in our tests that went from a warning
to an error in Python 3.12 (see
https://github.com/python/cpython/issues/100690)

# Which issue(s) this PR closes

Closes #4358
Closes https://github.com/grafana/oncall/issues/4387
2024-06-10 15:33:37 -04:00
Joey Orlando
6309bf0d41
update github actions versions 2024-06-07 11:07:29 -04:00
Joey Orlando
2e1021573e
debugging push to gcom step 2024-06-05 14:41:29 -04:00
Joey Orlando
3ff8f07b65
yaml linting 2024-06-05 14:24:04 -04:00
Joey Orlando
705bdb1d5a
github actions workflows - wip 2024-06-05 13:46:07 -04:00
Joey Orlando
cdd8354702
update on release published permissions 2024-06-05 12:33:18 -04:00
Joey Orlando
8910a9abd2
Drone -> GitHub Actions migration (#4466)
# What this PR does

Related to https://github.com/grafana/oncall-private/issues/2691
2024-06-05 12:25:53 -04:00