centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Simplify and speed up slack rendering (#1105)

Browse source 
Simplify and speed up slack rendering.
This commit is contained in:
Innokentii Konstantinov 2023-01-10 15:41:38 +08:00 • committed by GitHub
parent 86436f9f15
commit fa6906a606
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 52 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
engine/apps/alerts/incident_appearance/renderers/slack_renderer.py
View file

@ -74,41 +74,14 @@ class AlertGroupSlackRenderer(AlertGroupBaseRenderer):
return AlertSlackRenderer
def render_alert_group_blocks(self):
non_resolve_alerts_queryset = self.alert_group.alerts.filter(is_resolve_signal=False)
if not self.alert_group.channel.organization.slack_team_identity.installed_via_granular_permissions:
blocks = [
{
"type": "section",
"text": {
"type": "mrkdwn",
"text": ":warning: *Action required - reinstall app*\n"
"Slack is deprecating current permission model. We will support it till DATE\n" # TODO: deprecation date
"Don't worry - we migrate OnCall to new one, but it required to reinstall app."
'Press "Upgrade" button to see more detailed instruction and upgrade.',
},
},
{"type": "divider"},
{
"type": "actions",
"elements": [
{
"type": "button",
"text": {
"type": "plain_text",
"text": "Upgrade",
},
"value": "click_me_123",
"url": self.alert_group.channel.organization.web_slack_page_link,
},
],
},
]
else:
blocks = []
if non_resolve_alerts_queryset.count() <= 1:
blocks.extend(self.alert_renderer.render_alert_blocks())
else:
blocks.extend(self._get_alert_group_base_blocks_if_grouped())
blocks = self.alert_renderer.render_alert_blocks()
alerts_count = self.alert_group.alerts.count()
if alerts_count > 1:
text = (
f":package: Showing the last alert only out of {alerts_count} total. "
f"Visit <{self.alert_group.web_link}|the plugin page> to see them all."
)
blocks.append({"type": "context", "elements": [{"type": "mrkdwn", "text": text}]})
return blocks
def render_alert_group_attachments(self):
@ -189,23 +162,6 @@ class AlertGroupSlackRenderer(AlertGroupBaseRenderer):
attachment["color"] = color
return attachments
def _get_text_alert_grouped(self):
alert_count = self.alert_group.alerts.count()
link = self.alert_group.web_link
text = (
f":package: Showing the last alert only out of {alert_count} total. "
f"Visit <{link}|the plugin page> to see them all."
)
return text
def _get_alert_group_base_blocks_if_grouped(self):
text = self._get_text_alert_grouped()
blocks = self.alert_renderer.render_alert_blocks()
blocks.append({"type": "context", "elements": [{"type": "mrkdwn", "text": text}]})
return blocks
def _get_buttons_attachments(self):
attachment = {"blocks": self._get_buttons_blocks()}
return attachment