centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revalidate all when any settings change instead of making a special case for twilio

Browse source
This commit is contained in:
Michael Derynck 2022-10-20 10:11:36 -06:00
parent 363f019356
commit ef37e6a6fd
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
engine/apps/base/models/live_setting.py
View file

@ -187,20 +187,18 @@ class LiveSetting(models.Model):
def populate_settings_if_needed(cls):
settings_in_db = cls.objects.filter(name__in=cls.AVAILABLE_NAMES).values_list("name", flat=True)
setting_names_to_populate = set(cls.AVAILABLE_NAMES) - set(settings_in_db)
if len(setting_names_to_populate) == 0:
return
revalidate_twilio = False
for setting_name in setting_names_to_populate:
setting = cls.objects.create(name=setting_name, value=cls._get_setting_from_setting_file(setting_name))
if setting.name.startswith("TWILIO"):
revalidate_twilio = True
cls.objects.create(name=setting_name, value=cls._get_setting_from_setting_file(setting_name))
if revalidate_twilio:
cls.revalidate_twilio()
cls.revalidate_settings()
@classmethod
def revalidate_twilio(cls):
twilio_settings = cls.objects.filter(name__startswith="TWILIO")
for setting in twilio_settings:
def revalidate_settings(cls):
settings_to_validate = cls.objects.all()
for setting in settings_to_validate:
setting.error = LiveSettingValidator(live_setting=setting).get_error()
setting.save(update_fields=["error"])