From e87bb912ae843af479791fb389b6e3033182437a Mon Sep 17 00:00:00 2001
From: Rares Mardare <rares.mardare@grafana.com>
Date: Thu, 10 Aug 2023 09:35:32 +0300
Subject: [PATCH] Use UserSettingsWrite instead of OtherSettingsWrite for phone
 tab (#2772)

# What this PR does

Sets the correct permission when accessing Phone Verification screen
(Cloud/OSS)

## Which issue(s) this PR fixes

Fix for https://github.com/grafana/oncall/issues/2761

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
---
 CHANGELOG.md                                                    | 1 +
 .../parts/tabs/CloudPhoneSettings/CloudPhoneSettings.tsx        | 2 +-
 .../parts/tabs/PhoneVerification/PhoneVerification.tsx          | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a5fde585..8b896403 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Do not show override shortcut when web overrides are disabled ([#2745](https://github.com/grafana/oncall/pull/2745))
 - Handle ical schedule import with duplicated event UIDs ([#2760](https://github.com/grafana/oncall/pull/2760))
+- Allow Editor to access Phone Verification ([#2772](https://github.com/grafana/oncall/pull/2772))
 
 ## v1.3.22 (2023-08-03)
 
diff --git a/grafana-plugin/src/containers/UserSettings/parts/tabs/CloudPhoneSettings/CloudPhoneSettings.tsx b/grafana-plugin/src/containers/UserSettings/parts/tabs/CloudPhoneSettings/CloudPhoneSettings.tsx
index 0b7614d1..29809d02 100644
--- a/grafana-plugin/src/containers/UserSettings/parts/tabs/CloudPhoneSettings/CloudPhoneSettings.tsx
+++ b/grafana-plugin/src/containers/UserSettings/parts/tabs/CloudPhoneSettings/CloudPhoneSettings.tsx
@@ -112,7 +112,7 @@ const CloudPhoneSettings = observer((props: CloudPhoneSettingsProps) => {
 
   return (
     <WithPermissionControlDisplay
-      userAction={UserActions.OtherSettingsWrite}
+      userAction={UserActions.UserSettingsWrite}
       title="OnCall uses Grafana Cloud for SMS and phone call notifications"
     >
       <VerticalGroup spacing="lg">
diff --git a/grafana-plugin/src/containers/UserSettings/parts/tabs/PhoneVerification/PhoneVerification.tsx b/grafana-plugin/src/containers/UserSettings/parts/tabs/PhoneVerification/PhoneVerification.tsx
index f7ffe8e7..a354c0f0 100644
--- a/grafana-plugin/src/containers/UserSettings/parts/tabs/PhoneVerification/PhoneVerification.tsx
+++ b/grafana-plugin/src/containers/UserSettings/parts/tabs/PhoneVerification/PhoneVerification.tsx
@@ -188,7 +188,7 @@ const PhoneVerification = observer((props: PhoneVerificationProps) => {
   }
 
   return (
-    <WithPermissionControlDisplay userAction={UserActions.OtherSettingsWrite}>
+    <WithPermissionControlDisplay userAction={UserActions.UserSettingsWrite}>
       <VerticalGroup>
         {isPhoneValid && !user.verified_phone_number && (
           <Alert severity="info" title="You will receive alerts to a new number after verification" />