centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #980 from grafana/matiasb/fix-schedules-types-ui

Browse source 
Fix schedules types UI confusion
This commit is contained in:
Matias Bordese 2022-12-12 16:54:18 -03:00 • committed by GitHub
commit d2d73093a8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
grafana-plugin/src/components/NewScheduleSelector/NewScheduleSelector.tsx
View file

@ -50,7 +50,7 @@ const NewScheduleSelector: FC<NewScheduleSelectorProps> = (props) => {
</VerticalGroup>
</HorizontalGroup>
<WithPermissionControl userAction={UserActions.SchedulesWrite}>
<Button variant="primary" icon="plus" onClick={getCreateScheduleClickHandler(ScheduleType.Calendar)}>
<Button variant="primary" icon="plus" onClick={getCreateScheduleClickHandler(ScheduleType.API)}>
Create
</Button>
</WithPermissionControl>

4
grafana-plugin/src/components/SchedulesFilters_NEW/SchedulesFilters.tsx
View file

@ -72,7 +72,7 @@ const SchedulesFilters = (props: SchedulesFiltersProps) => {
{ label: 'All', value: undefined },
{
label: 'Web',
value: ScheduleType.Calendar,
value: ScheduleType.API,
},
{
label: 'ICal',
@ -80,7 +80,7 @@ const SchedulesFilters = (props: SchedulesFiltersProps) => {
},
{
label: 'API',
value: ScheduleType.API,
value: ScheduleType.Calendar,
},
]}
value={value?.type}

4
grafana-plugin/src/models/schedule/schedule.types.ts
View file

@ -6,9 +6,9 @@ import { User } from 'models/user/user.types';
import { UserGroup } from 'models/user_group/user_group.types';
export enum ScheduleType {
'API',
'Ical',
'Calendar',
'Ical',
'API',
}
export interface RotationFormLiveParams {

2
grafana-plugin/src/pages/schedules/Schedules.tsx
View file

@ -209,7 +209,7 @@ class SchedulesPage extends React.Component<SchedulesPageProps, SchedulesPageSta
};
handleCreateSchedule = (data: Schedule) => {
if (data.type === ScheduleType.Calendar) {
if (data.type === ScheduleType.API) {
LocationHelper.update({ page: 'schedule', id: data.id }, 'partial');
}
};