centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: capitalize Slack name references (#5421)

Browse source 
Related to https://github.com/grafana/irm/issues/425
This commit is contained in:
Matias Bordese 2025-01-21 14:05:39 -03:00 • committed by GitHub
parent 84411b7250
commit cc356c9d54
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
engine/apps/alerts/incident_log_builder/incident_log_builder.py
View file

@ -536,7 +536,7 @@ class IncidentLogBuilder:
)
else:
plan_line = (
f'escalation step "{escalation_policy_snapshot.step_display}" is slack specific. ' f"Skipping"
f'escalation step "{escalation_policy_snapshot.step_display}" is Slack specific. ' f"Skipping"
)
escalation_plan.setdefault(timedelta, []).append({"plan_lines": [plan_line]})
@ -597,7 +597,7 @@ class IncidentLogBuilder:
)
else:
plan_line = (
f'escalation step "{escalation_policy_snapshot.step_display}" is slack specific. Skipping'
f'escalation step "{escalation_policy_snapshot.step_display}" is Slack specific. Skipping'
)
escalation_plan.setdefault(timedelta, []).append({"plan_lines": [plan_line]})

2
engine/apps/alerts/tasks/notify_user.py
View file

@ -252,7 +252,7 @@ def notify_user_task(
type=UserNotificationPolicyLogRecord.TYPE_PERSONAL_NOTIFICATION_FAILED,
notification_policy=notification_policy,
alert_group=alert_group,
reason="Alert group slack notifications are disabled",
reason="Alert group Slack notifications are disabled",
slack_prevent_posting=prevent_posting_to_thread,
notification_step=notification_policy.step,
notification_channel=notification_policy.notify_by,

2
engine/apps/api/views/schedule.py
View file

@ -567,7 +567,7 @@ class ScheduleView(
},
{
"value": True,
"display_name": "Mention person in slack",
"display_name": "Mention person in Slack",
},
]
return Response(options)

2
engine/apps/slack/scenarios/resolution_note.py
View file

@ -558,7 +558,7 @@ class ResolutionNoteModalStep(AlertGroupActionsMixin, scenario_step.ScenarioStep
user_verbal = resolution_note.author_verbal(mention=True)
message_timestamp = datetime.datetime.timestamp(resolution_note.created_at)
blocks.append(DIVIDER)
source = "web" if resolution_note.source == ResolutionNote.Source.WEB else "slack"
source = "web" if resolution_note.source == ResolutionNote.Source.WEB else "Slack"
blocks.append(
typing.cast(

4
engine/apps/slack/scenarios/schedules.py
View file

@ -26,8 +26,8 @@ if typing.TYPE_CHECKING:
class EditScheduleShiftNotifyStep(scenario_step.ScenarioStep):
notify_empty_oncall_options = {choice[0]: choice[1] for choice in OnCallSchedule.NotifyEmptyOnCall.choices}
notify_oncall_shift_freq_options = {choice[0]: choice[1] for choice in OnCallSchedule.NotifyOnCallShiftFreq.choices}
mention_oncall_start_options = {1: "Mention person in slack", 0: "Inform in channel without mention"}
mention_oncall_next_options = {1: "Mention person in slack", 0: "Inform in channel without mention"}
mention_oncall_start_options = {1: "Mention person in Slack", 0: "Inform in channel without mention"}
mention_oncall_next_options = {1: "Mention person in Slack", 0: "Inform in channel without mention"}
def process_scenario(
self,

2
engine/apps/slack/views.py
View file

@ -586,7 +586,7 @@ class ResetSlackView(APIView):
# just a placeholder value to continute uninstallation until UNIFIED_SLACK_APP_ENABLED is not enabled
removed = True
if not removed:
return Response({"error": "Failed to uninstall slack integration"}, status=500)
return Response({"error": "Failed to uninstall Slack integration"}, status=500)
try:
uninstall_slack_integration(request.user.organization, request.user)