centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Disable listing alert groups using Grafana Incident API (#1279)

Browse source 
Grafana Incident API only ever accesses individual alert groups by ID.
Using the /api/gi/v1/alert-groups endpoint without an ID would list
every
single alert group in the database (from what I can tell), since the
auth
isn't org-specific.

This is a precursor to another PR which adds more details to the alert
group
serializer, which makes the query more resource intensive, so I thought
it
best to disable listing first.
This commit is contained in:
Ben Sully 2023-02-03 12:26:03 +00:00 • committed by GitHub
parent 930f1f9edf
commit cb98751c0f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
engine/apps/api_for_grafana_incident/views.py
View file

@ -1,4 +1,4 @@
from rest_framework.viewsets import ReadOnlyModelViewSet
from rest_framework import mixins, viewsets
from apps.alerts.models import AlertGroup
from apps.auth_token.auth import GrafanaIncidentStaticKeyAuth
@ -6,7 +6,13 @@ from apps.auth_token.auth import GrafanaIncidentStaticKeyAuth
from .serializers import AlertGroupSerializer
class AlertGroupsView(ReadOnlyModelViewSet):
class RetrieveViewSet(mixins.RetrieveModelMixin, viewsets.GenericViewSet):
"""
A viewset that provides only `retrieve` actions.
"""
class AlertGroupsView(RetrieveViewSet):
authentication_classes = (GrafanaIncidentStaticKeyAuth,)
queryset = AlertGroup.unarchived_objects.all()
serializer_class = AlertGroupSerializer