centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "Enable push notifications for SSR beneficiary for testing purposes" (#2757)

Browse source 
Reverts grafana/oncall#2752
This commit is contained in:
Vadim Stepanov 2023-08-04 16:13:03 +01:00 • committed by GitHub
parent 8412282569
commit bc78fc29e5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
engine/apps/schedules/models/shift_swap_request.py
View file

@ -157,9 +157,7 @@ class ShiftSwapRequest(models.Model):
@property
def possible_benefactors(self) -> QuerySet["User"]:
# TODO: exclude the beneficiary from this list
# Temporarily including the beneficiary in the list of possible benefactors for testing purposes
return self.schedule.related_users()
return self.schedule.related_users().exclude(pk=self.beneficiary_id)
@property
def web_link(self) -> str:

4
engine/apps/schedules/tests/test_shift_swap_request.py
View file

@ -166,6 +166,4 @@ def test_possible_benefactors(shift_swap_request_setup) -> None:
with patch.object(ssr.schedule, "related_users") as mock_related_users:
mock_related_users.return_value = User.objects.filter(pk__in=[beneficiary.pk, benefactor.pk])
# TODO: exclude the beneficiary from this list
# Temporarily including the beneficiary in the list of possible benefactors for testing purposes
assert set(ssr.possible_benefactors) == {benefactor, beneficiary}
assert list(ssr.possible_benefactors) == [benefactor]