From b68dd9bc92a00b9962526076da8eb2bb1e0031a7 Mon Sep 17 00:00:00 2001 From: Vadim Stepanov Date: Wed, 7 Sep 2022 10:58:31 +0100 Subject: [PATCH] fix deleting the last notification rule for pagerduty migrator (#484) --- .../migrator/resources/notification_rules.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/pagerduty-migrator/migrator/resources/notification_rules.py b/tools/pagerduty-migrator/migrator/resources/notification_rules.py index e3efb2f5..39b7a39a 100644 --- a/tools/pagerduty-migrator/migrator/resources/notification_rules.py +++ b/tools/pagerduty-migrator/migrator/resources/notification_rules.py @@ -31,12 +31,16 @@ def migrate_notification_rules(user: dict) -> None: notification_rules, user["oncall_user"]["id"] ) - for rule in user["oncall_user"]["notification_rules"]: - oncall_api_client.delete("personal_notification_rules/{}".format(rule["id"])) - for rule in oncall_rules: oncall_api_client.create("personal_notification_rules", rule) + if oncall_rules: + # delete old notification rules if any new rules were created + for rule in user["oncall_user"]["notification_rules"]: + oncall_api_client.delete( + "personal_notification_rules/{}".format(rule["id"]) + ) + def transform_notification_rules( notification_rules: list[dict], user_id: str