From 8c5f6238dc3ef916960585e2e89bcfc7ff9da57d Mon Sep 17 00:00:00 2001 From: Joey Orlando Date: Mon, 12 Jun 2023 15:43:05 +0200 Subject: [PATCH] get rid of need for FEATURE_PROMETHEUS_EXPORTER_ENABLED to be present in ci-test.py settings file (#2161) --- engine/apps/metrics_exporter/tests/test_views.py | 6 +++++- engine/settings/ci-test.py | 2 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/engine/apps/metrics_exporter/tests/test_views.py b/engine/apps/metrics_exporter/tests/test_views.py index 3a2381c9..8793539d 100644 --- a/engine/apps/metrics_exporter/tests/test_views.py +++ b/engine/apps/metrics_exporter/tests/test_views.py @@ -1,4 +1,5 @@ import pytest +from django.test import override_settings from django.urls import reverse from rest_framework.test import APIClient @@ -12,7 +13,10 @@ from rest_framework.test import APIClient ("secret", "secret", 200), ], ) -def test_metrics_exporter_auth(settings, token, auth, expected): +@override_settings(FEATURE_PROMETHEUS_EXPORTER_ENABLED=True) +def test_metrics_exporter_auth(settings, reload_urls, token, auth, expected): + reload_urls() + settings.PROMETHEUS_EXPORTER_SECRET = token client = APIClient() diff --git a/engine/settings/ci-test.py b/engine/settings/ci-test.py index fa03e76c..9751c49d 100644 --- a/engine/settings/ci-test.py +++ b/engine/settings/ci-test.py @@ -40,5 +40,3 @@ TWILIO_ACCOUNT_SID = "dummy_twilio_account_sid" TWILIO_AUTH_TOKEN = "dummy_twilio_auth_token" EXTRA_MESSAGING_BACKENDS = [("apps.base.tests.messaging_backend.TestOnlyBackend", 42)] - -FEATURE_PROMETHEUS_EXPORTER_ENABLED = True