From d036864d9a7080cea6bcb9fc4199e71c8cfdeaff Mon Sep 17 00:00:00 2001 From: Ildar Iskhakov Date: Thu, 4 Aug 2022 12:27:08 +0300 Subject: [PATCH 1/3] Fix resolution notes bug --- engine/apps/slack/scenarios/resolution_note.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/apps/slack/scenarios/resolution_note.py b/engine/apps/slack/scenarios/resolution_note.py index f6c78305..ab4488e9 100644 --- a/engine/apps/slack/scenarios/resolution_note.py +++ b/engine/apps/slack/scenarios/resolution_note.py @@ -704,7 +704,7 @@ class AddRemoveThreadMessageStep(UpdateResolutionNoteStep, scenario_step.Scenari # Show error message resolution_note_data = json.loads(payload["actions"][0]["value"]) resolution_note_data["resolution_note_window_action"] = "edit_update_error" - return ResolutionNoteModalStep(slack_team_identity).process_scenario( + return ResolutionNoteModalStep(slack_team_identity, self.organization, self.user).process_scenario( slack_user_identity, slack_team_identity, payload, From 4e16767eaa33b9821af5e4b33943e05e852a09d9 Mon Sep 17 00:00:00 2001 From: Ildar Iskhakov Date: Thu, 4 Aug 2022 13:37:15 +0300 Subject: [PATCH 2/3] Cleanup unused code --- engine/apps/slack/scenarios/resolution_note.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/engine/apps/slack/scenarios/resolution_note.py b/engine/apps/slack/scenarios/resolution_note.py index ab4488e9..cec692c6 100644 --- a/engine/apps/slack/scenarios/resolution_note.py +++ b/engine/apps/slack/scenarios/resolution_note.py @@ -133,8 +133,6 @@ class AddToResolutionNoteStep(CheckAlertIsUnarchivedMixin, scenario_step.Scenari ).save() else: resolution_note.recreate() - alert_group.drop_cached_after_resolve_report_json() - alert_group.schedule_cache_for_web() try: self._slack_client.api_call( "reactions.add", From 20e476b68eceb7dcc36627e3e1fe18d79d297ceb Mon Sep 17 00:00:00 2001 From: Ildar Iskhakov Date: Thu, 4 Aug 2022 13:41:59 +0300 Subject: [PATCH 3/3] Fix docs --- docs/sources/open-source.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/sources/open-source.md b/docs/sources/open-source.md index e6032929..c485e810 100644 --- a/docs/sources/open-source.md +++ b/docs/sources/open-source.md @@ -79,10 +79,10 @@ lt --port 8080 -s pretty-turkey-83 --print-requests type: message callback_id: incident_create description: Creates a new OnCall incident - - name: Add to postmortem + - name: Add to resolution note type: message - callback_id: add_postmortem - description: Add this message to postmortem + callback_id: add_resolution_note + description: Add this message to resolution note slash_commands: - command: /oncall url: /slack/interactive_api_endpoint/