From 840669235acc779af4df658eda73bbc332070f5b Mon Sep 17 00:00:00 2001 From: Ildar Iskhakov Date: Tue, 4 Apr 2023 11:57:38 +0800 Subject: [PATCH] Disable mentions when resolution note is created (#1696) # What this PR does ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --- CHANGELOG.md | 11 +++++++---- engine/apps/slack/scenarios/resolution_note.py | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c6346991..a707ba8f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased + +### Changed + +- Disable mentions when resolution note is created by @iskhakov ([1696](https://github.com/grafana/oncall/pull/1696)) + ## v1.2.7 (2023-04-03) ### Added @@ -14,16 +20,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Renamed routes from /incidents to /alert-groups ([#1678](https://github.com/grafana/oncall/pull/1678)) +- Display warnings on users page in a clean and consistent way by @iskhakov ([#1681](https://github.com/grafana/oncall/pull/1681)) ### Fixed - Fix team search when filtering resources by @vadimkerr ([#1680](https://github.com/grafana/oncall/pull/1680)) - Fix issue when trying to scroll in Safari ([#415](https://github.com/grafana/oncall/issues/415)) -### Changed - -- Display warnings on users page in a clean and consistent way by @iskhakov ([#1681](https://github.com/grafana/oncall/pull/1681)) - ## v1.2.6 (2023-03-30) ### Fixed diff --git a/engine/apps/slack/scenarios/resolution_note.py b/engine/apps/slack/scenarios/resolution_note.py index 94c2a8df..72a014e8 100644 --- a/engine/apps/slack/scenarios/resolution_note.py +++ b/engine/apps/slack/scenarios/resolution_note.py @@ -352,7 +352,7 @@ class UpdateResolutionNoteStep(scenario_step.ScenarioStep): def get_resolution_note_blocks(self, resolution_note): blocks = [] - author_verbal = resolution_note.author_verbal(mention=True) + author_verbal = resolution_note.author_verbal(mention=False) resolution_note_text_block = { "type": "section", "text": {"type": "mrkdwn", "text": resolution_note.text},