From 54b81e6dd8b93327327f3bc10c77ef3e96a6e52a Mon Sep 17 00:00:00 2001 From: Maxim Mordasov Date: Fri, 2 Feb 2024 13:35:04 +0300 Subject: [PATCH] fix deps list in rotation form (#3815) # What this PR does Fix incorrect end date on creating weekly on-call shift ## Which issue(s) this PR fixes https://github.com/grafana/oncall/issues/3755 ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --- CHANGELOG.md | 4 ++++ grafana-plugin/src/containers/RotationForm/RotationForm.tsx | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index eec810b2..50533f3f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Render alert group action buttons even if getting AG data fails ([#2383](https://github.com/grafana/oncall-private/issues/2383)) - Enable Grafana Alerting V2 feature flag by default +### Fixed + +- Incorrect end date on creating weekly on-call shift ([#3755](https://github.com/grafana/oncall/issues/3755)) + ## v1.3.98 (2024-02-01) ### Fixed diff --git a/grafana-plugin/src/containers/RotationForm/RotationForm.tsx b/grafana-plugin/src/containers/RotationForm/RotationForm.tsx index bcad0a8b..8458df61 100644 --- a/grafana-plugin/src/containers/RotationForm/RotationForm.tsx +++ b/grafana-plugin/src/containers/RotationForm/RotationForm.tsx @@ -284,7 +284,7 @@ const RotationForm = observer((props: RotationFormProps) => { } } }, - [showActiveOnSelectedPartOfDay, showActiveOnSelectedDays, repeatEveryValue] + [showActiveOnSelectedPartOfDay, showActiveOnSelectedDays, repeatEveryValue, shiftStart] ); const handleRepeatEveryValueChange = (option) => {