centralcloud/oncall-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove duplicate plugin.json routes (#4069)

Browse source 
# What this PR does

I'm _fairly_ certain these are duplicates of this 👇 route that already
exists in our `plugin.json`
([here](https://github.com/grafana/oncall/blob/dev/grafana-plugin/src/plugin.json#L184C5-L198C6)):
```json
{
  "path": "api/internal/v1/*",
  "method": "*",
  "url": "{{ .JsonData.onCallApiUrl }}/api/internal/v1/",
  "headers": [
    {
      "name": "X-Instance-Context",
      "content": "{ \"stack_id\": \"{{ printf \"%.0f\" .JsonData.stackId }}\", \"org_id\": \"{{ printf \"%.0f\" .JsonData.orgId }}\" }"
    },
    {
      "name": "Authorization",
      "content": "{{ .SecureJsonData.onCallApiToken }}"
    }
  ]
}
```

all of the headers being sent are identical + the `api/internal/v1/*`
route should forward all of these deleted routes to the right
`api/internal/v1` api endpoint

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
This commit is contained in:
Joey Orlando 2024-03-18 02:36:54 -04:00 • committed by GitHub
parent 65b4a23407
commit 3897e89af7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
grafana-plugin/src/plugin.json
View file

@ -136,51 +136,6 @@
}
]
},
{
"path": "api/internal/v1/plugin/sync",
"method": "*",
"url": "{{ .JsonData.onCallApiUrl }}/api/internal/v1/plugin/sync",
"headers": [
{
"name": "X-Instance-Context",
"content": "{ \"stack_id\": \"{{ printf \"%.0f\" .JsonData.stackId }}\", \"org_id\": \"{{ printf \"%.0f\" .JsonData.orgId }}\" }"
},
{
"name": "Authorization",
"content": "{{ .SecureJsonData.onCallApiToken }}"
}
]
},
{
"path": "api/internal/v1/plugin/*",
"method": "*",
"url": "{{ .JsonData.onCallApiUrl }}/api/internal/v1/plugin/",
"headers": [
{
"name": "X-Instance-Context",
"content": "{ \"stack_id\": \"{{ printf \"%.0f\" .JsonData.stackId }}\", \"org_id\": \"{{ printf \"%.0f\" .JsonData.orgId }}\" }"
},
{
"name": "Authorization",
"content": "{{ .SecureJsonData.onCallApiToken }}"
}
]
},
{
"path": "api/internal/v1/login/slack-install-free/",
"method": "*",
"url": "{{ .JsonData.onCallApiUrl }}/api/internal/v1/login/slack-install-free/",
"headers": [
{
"name": "X-Instance-Context",
"content": "{ \"stack_id\": \"{{ printf \"%.0f\" .JsonData.stackId }}\", \"org_id\": \"{{ printf \"%.0f\" .JsonData.orgId }}\" }"
},
{
"name": "Authorization",
"content": "{{ .SecureJsonData.onCallApiToken }}"
}
]
},
{
"path": "api/internal/v1/*",
"method": "*",