From 37d25b5b31019f477b0dfdf22fd6c5f240212d30 Mon Sep 17 00:00:00 2001
From: Ildar Iskhakov <Ildar.iskhakov@grafana.com>
Date: Mon, 23 Jan 2023 16:07:55 +0800
Subject: [PATCH] Optimize alert group filtering queries (#1191)

# What this PR does

## Which issue(s) this PR fixes

## Checklist

- [ ] Tests updated
- [ ] Documentation added
- [ ] `CHANGELOG.md` updated
---
 engine/apps/alerts/models/alert_group.py | 28 ++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/engine/apps/alerts/models/alert_group.py b/engine/apps/alerts/models/alert_group.py
index ee5b6a8d..fe7cdfc5 100644
--- a/engine/apps/alerts/models/alert_group.py
+++ b/engine/apps/alerts/models/alert_group.py
@@ -351,19 +351,39 @@ class AlertGroup(AlertGroupSlackRenderingMixin, EscalationSnapshotMixin, models.
 
     @staticmethod
     def get_silenced_state_filter():
-        return Q(silenced=True) & Q(acknowledged=False) & Q(resolved=False)
+        """
+        models.Value(0/1) is used instead of True/False because django translates that into
+        WHERE bool_field=0/1 instead of WHERE bool_field/NOT bool_field
+        which works much faster in mysql
+        """
+        return Q(silenced=models.Value("1")) & Q(acknowledged=models.Value("0")) & Q(resolved=models.Value("0"))
 
     @staticmethod
     def get_new_state_filter():
-        return Q(silenced=False) & Q(acknowledged=False) & Q(resolved=False)
+        """
+        models.Value(0/1) is used instead of True/False because django translates that into
+        WHERE bool_field=0/1 instead of WHERE bool_field/NOT bool_field
+        which works much faster in mysql
+        """
+        return Q(silenced=models.Value("0")) & Q(acknowledged=models.Value("0")) & Q(resolved=models.Value("0"))
 
     @staticmethod
     def get_acknowledged_state_filter():
-        return Q(acknowledged=True) & Q(resolved=False)
+        """
+        models.Value(0/1) is used instead of True/False because django translates that into
+        WHERE bool_field=0/1 instead of WHERE bool_field/NOT bool_field
+        which works much faster in mysql
+        """
+        return Q(acknowledged=models.Value("1")) & Q(resolved=models.Value("0"))
 
     @staticmethod
     def get_resolved_state_filter():
-        return Q(resolved=True)
+        """
+        models.Value(0/1) is used instead of True/False because django translates that into
+        WHERE bool_field=0/1 instead of WHERE bool_field/NOT bool_field
+        which works much faster in mysql
+        """
+        return Q(resolved=models.Value("1"))
 
     class Meta:
         get_latest_by = "pk"