From 348ccb8653655f14aeaa4ae68c112e37552911ef Mon Sep 17 00:00:00 2001 From: Joey Orlando Date: Fri, 12 Jan 2024 15:19:43 -0500 Subject: [PATCH] unskip escalation policy test (#3678) --- .../escalationChains/escalationPolicy.test.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/grafana-plugin/e2e-tests/escalationChains/escalationPolicy.test.ts b/grafana-plugin/e2e-tests/escalationChains/escalationPolicy.test.ts index ecf44db0..fd07ef2d 100644 --- a/grafana-plugin/e2e-tests/escalationChains/escalationPolicy.test.ts +++ b/grafana-plugin/e2e-tests/escalationChains/escalationPolicy.test.ts @@ -16,12 +16,11 @@ test('escalation policy does not go back to "Default" after adding users to noti await expect(page.getByText('Important')).toBeVisible(); }); -// TODO: unskip when https://github.com/grafana/oncall/issues/3585 is patched -test.skip('from_time and to_time for "Continue escalation if current UTC time is in range" escalation step type can be properly updated', async ({ +test('from_time and to_time for "Continue escalation if current UTC time is in range" escalation step type can be properly updated', async ({ adminRolePage, }) => { - const FROM_TIME = '10:31'; - const TO_TIME = '10:32'; + const FROM_TIME = '10:30'; + const TO_TIME = '10:35'; const { page } = adminRolePage; const escalationChainName = generateRandomValue(); @@ -54,6 +53,6 @@ test.skip('from_time and to_time for "Continue escalation if current UTC time is await page.reload(); await page.waitForLoadState('networkidle'); - expect(await _getFromTimeInput().textContent()).toBe(FROM_TIME); - expect(await _getToTimeInput().textContent()).toBe(FROM_TIME); + expect(_getFromTimeInput()).toHaveValue(FROM_TIME); + expect(_getToTimeInput()).toHaveValue(TO_TIME); });